Skip to content

refactor: remove unnecessary async iterator checks #15435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
+8 −26
Merged

refactor: remove unnecessary async iterator checks #15435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
848478a
refactor: remove unnecessary async iterator checks
vkarpov15 May 26, 2025
56137d4
style: fix lint
vkarpov15 May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions lib/aggregate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,24 +1139,15 @@ Aggregate.prototype.finally = function(onFinally) {
* console.log(doc.name);
* }
*
* Node.js 10.x supports async iterators natively without any flags. You can
* enable async iterators in Node.js 8.x using the [`--harmony_async_iteration` flag](https://github.com/tc39/proposal-async-iteration/issues/117#issuecomment-346695187).
*
* **Note:** This function is not set if `Symbol.asyncIterator` is undefined. If
* `Symbol.asyncIterator` is undefined, that means your Node.js version does not
* support async iterators.
*
* @method [Symbol.asyncIterator]
* @memberOf Aggregate
* @instance
* @api public
*/

if (Symbol.asyncIterator != null) {
Aggregate.prototype[Symbol.asyncIterator] = function() {
return this.cursor({ useMongooseAggCursor: true }).transformNull()._transformForAsyncIterator();
};
}
Aggregate.prototype[Symbol.asyncIterator] = function() {
return this.cursor({ useMongooseAggCursor: true }).transformNull()._transformForAsyncIterator();
};

/*!
* Helpers
Expand Down
19 changes: 5 additions & 14 deletions lib/query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5406,26 +5406,17 @@ Query.prototype.nearSphere = function() {
* console.log(doc.name);
* }
*
* Node.js 10.x supports async iterators natively without any flags. You can
* enable async iterators in Node.js 8.x using the [`--harmony_async_iteration` flag](https://github.com/tc39/proposal-async-iteration/issues/117#issuecomment-346695187).
*
* **Note:** This function is not if `Symbol.asyncIterator` is undefined. If
* `Symbol.asyncIterator` is undefined, that means your Node.js version does not
* support async iterators.
*
* @method [Symbol.asyncIterator]
* @memberOf Query
* @instance
* @api public
*/

if (Symbol.asyncIterator != null) {
Query.prototype[Symbol.asyncIterator] = function queryAsyncIterator() {
// Set so QueryCursor knows it should transform results for async iterators into `{ value, done }` syntax
this._mongooseOptions._asyncIterator = true;
return this.cursor();
};
}
Query.prototype[Symbol.asyncIterator] = function queryAsyncIterator() {
// Set so QueryCursor knows it should transform results for async iterators into `{ value, done }` syntax
this._mongooseOptions._asyncIterator = true;
return this.cursor();
};

/**
* Specifies a `$polygon` condition
Expand Down