Skip to content

docs: add Document#save to list of function with callbacks removed #15433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented May 24, 2025

Summary

(This PR is very similar to my previous PR regarding Model#count, so I've largely copy and pasted the description over.)

I'm working on migrating from Mongoose v6 to Mongoose v7. Part of this includes dropping all callbacks in favor of Promises.

I noticed that Document#save is not in the list though, which according to the types, had a callback param in v6, which was removed in v7. This should be in the list of functions as well that the callback param was removed from too.

Examples

N/A

Notes for Reviewers

The failed test case seems to be unrelated to this PR.

@vkarpov15 vkarpov15 merged commit 37134b0 into Automattic:master May 25, 2025
2 of 3 checks passed
@vkarpov15 vkarpov15 added this to the 8.15.1 milestone May 25, 2025
@SethFalco SethFalco deleted the patch-1 branch May 25, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants