Skip to content

8.15 #15426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 73 commits into from
May 16, 2025
Merged

8.15 #15426

merged 73 commits into from
May 16, 2025

Conversation

vkarpov15
Copy link
Collaborator

Summary

Just finishing up #15418 / #15327, otherwise should be ready to merge

Examples

baileympearson and others added 24 commits May 7, 2025 08:14
chore: comments on CSFLE feature branch PR#2
…ty-filter

Fix: Add strictFilter option to findOneAndUpdate (#14913)
Co-authored-by: hasezoey <hasezoey@gmail.com>
feat(error): set `cause` to MongoDB error `reason` on ServerSelection errors
fix(model): make bulkSave() rely on document.validate() to validate docs and skip bulkWrite casting
Co-authored-by: hasezoey <hasezoey@gmail.com>
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR completes the work on field-level encryption and query filtering for the project. Key changes include the introduction of the autoEncryptionType method on multiple schema types, modifications to schema encryption configuration and encrypted field handling, and updates to the query and bulkWrite operations to enforce non-empty filters.

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/schema/* Added autoEncryptionType methods to various schema types for encryption support.
lib/schema.js Updated schema encryption configuration and added functions to manage encrypted fields.
lib/query.js Introduced helper methods (isEmptyFilter and checkRequireFilter) and added filter validation in multiple query operations.
lib/model.js Modified bulkWrite and bulkSave logic to support encrypted models; refactored buildBulkWriteOperations.
lib/helpers/model/discriminator.js, docs, workflows, .eslintrc.js Updated to support the new encryption features and updated documentation/configuration accordingly.
Comments suppressed due to low confidence (1)

lib/model.js:3912

  • In the update branch of buildBulkWriteOperations, the variables 'where' and 'changes' are used without being defined. Consider restoring their assignment (e.g., 'const where = document.$__where(delta[0]);' and 'const changes = delta[1];') prior to using them.
document.$__version(where, delta);

types: stricter projection typing with 1-level deep nesting
@vkarpov15 vkarpov15 merged commit 5cf74e0 into master May 16, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants