fix: problematic asterisk operator computation #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In JavaScript, the operation
*of a number and a string that cannot be parsed into a number results inNaN, whereas in Python, the result is a string consisting of the original string repeated by the number used in the operation.This discrepency in operator behaviour between the languages can cause memory issues, if the resulting string is very large.
Solution
This PR aims to eliminate the problematic case and improve the behaviour simulation of JavaScript for the
*operation while not impeding the performance.Refactor Suggestion
As there are also differences in behaviour for various other operators, a refactor of the
compute_operatorsfunction could be considered. A PoC, that computes the operators via JavaScript using PyMiniRacer can be found here: main...Falanty:DoubleX:feat/js_operator_calculation_with_js_context.