Skip to content

Added a "dispose" method to PhaseLockedVocoder to clear the au wavetable #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 18, 2025
Merged

Added a "dispose" method to PhaseLockedVocoder to clear the au wavetable #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90a131b
Fixing a memory leak from not deallocating audio data pointer
maweibezahn May 8, 2025
003b954
Moved the deallocation of theData to the end
maweibezahn May 8, 2025
b418616
cleaned up unneeded deallocation in 164
maweibezahn May 9, 2025
a1c6c64
Added a "dispose" method to clear the au wavetable
maweibezahn May 14, 2025
e1e25c6
removed white space
maweibezahn May 14, 2025
74c8e3e
Corrected a default param value in ZitaReverb
maweibezahn May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SoundpipeAudioKit/Effects/ZitaReverb.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public class ZitaReverb: Node {
identifier: "EQ Frequency 2",
name: "EQ Frequency 2",
address: akGetParameterAddress("ZitaReverbParameterEqualizerFrequency2"),
defaultValue: 1500.0,
defaultValue: 1000.0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the default value was not in the value range. It was not a practical problem, but is more correct this way. See this issue: #41

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

range: 160.0 ... 1000.0,
unit: .hertz
)
Expand Down
12 changes: 9 additions & 3 deletions Sources/SoundpipeAudioKit/Generators/PhaseLockedVocoder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ public class PhaseLockedVocoder: Node {
self.amplitude = amplitude
self.pitchRatio = pitchRatio
}


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

/// Call this function after you are done with the node, to reset the au wavetable to prevent memory leaks
public func dispose() {
au.setWaveTable([0.0])
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

internal func loadFile(_ avAudioFile: AVAudioFile) {
Exit: do {
var err: OSStatus = noErr
Expand Down Expand Up @@ -160,10 +165,11 @@ public class PhaseLockedVocoder: Node {
au.setWavetable(data: data, size: Int(ioNumberFrames))
} else {
// failure
theData?.deallocate()
theData = nil // make sure to return NULL
Log("Error = \(err)"); break Exit
}
// Fixing a previous memory leak
theData?.deallocate()
theData = nil
}
}
}
Expand Down
Loading