Skip to content

fix: msdl fixed #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

fix: msdl fixed #256

merged 2 commits into from
Mar 28, 2025

Conversation

RadNotRed
Copy link
Member

Type

  • Rewrite already written documentation
  • Add/remove new pages

Questions

Describe your pull request

Fixed MSDL downloader

@jacksyrm jacksyrm enabled auto-merge (squash) March 28, 2025 20:20
@jacksyrm jacksyrm disabled auto-merge March 28, 2025 20:20
@jacksyrm jacksyrm merged commit 7c76d7b into Atlas-OS:main Mar 28, 2025
1 check passed
@RadNotRed RadNotRed requested a review from Copilot March 28, 2025 20:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the MSDL downloader by updating the API endpoints and simplifying the download logic.

  • Revised API URL usage and removed deprecated URL variables.
  • Simplified error handling and updated event binding methods.
  • Changed button text from “Submit” to “Download” and removed shared session logic.
Comments suppressed due to low confidence (1)

docs/javascript/msdl.v1.js:122

  • The variable winProductID is used to construct the download URL but is not assigned a value within this diff; please ensure it is properly initialized before usage to avoid unintended behavior.
let url = `${apiUrl}proxy?product_id=${winProductID}&sku_id=${skuId}`;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants