-
Notifications
You must be signed in to change notification settings - Fork 877
fix bitbucket and gitlab repo access #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bitbucket and gitlab repo access #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mzarnecki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug where Bitbucket and GitLab repository links were not being correctly recognized, leading to 404 errors. The fix enhances the application's ability to automatically determine the repository host from the provided URL, ensuring seamless access to non-GitHub repositories without requiring manual type selection.
Highlights
- Repository Type Detection: Modified the logic for determining the repository type (
repoType
) to prioritize automatic detection from therepo_url
query parameter. This change allows the application to correctly identify Bitbucket and GitLab repositories based on their URLs, resolving issues where they were incorrectly defaulting to GitHub.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue where the repository type for Bitbucket and GitLab was not being automatically detected from the repository URL. The change is logical and directly addresses the problem.
const repoType = repoUrl?.includes('bitbucket.org') | ||
? 'bitbucket' | ||
: repoUrl?.includes('gitlab.com') | ||
? 'gitlab' | ||
: repoUrl?.includes('github.com') | ||
? 'github' | ||
: searchParams.get('type') || 'github'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nested ternary operator can be difficult to read. An Immediately Invoked Function Expression (IIFE) can make the logic clearer.
const repoType = (() => {
if (repoUrl?.includes('bitbucket.org')) return 'bitbucket';
if (repoUrl?.includes('gitlab.com')) return 'gitlab';
if (repoUrl?.includes('github.com')) return 'github';
return searchParams.get('type') || 'github';
})();
In this PR I provide fix support for bitbucket and gitlab repository links.
repoType was chosen based on GET param which is "github" by default.

This GET param is changed only when "access token" section repository type is selected, but UI suggest that it's recognized automatically.
therefore when using suggested link for open bitbucket repository (https://bitbucket.org/atlassian/atlaskit) it end with 404 error message that comes from github related condition
Changed code to detect repository type from URL in first place.