-
Notifications
You must be signed in to change notification settings - Fork 877
fix support for bitbucket and gitlab repository links #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mzarnecki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug where the application incorrectly assumed a GitHub repository type, even when a Bitbucket or GitLab URL was provided, leading to 404 errors. My changes introduce a more robust mechanism to automatically detect the repository type directly from the repoUrl
, ensuring compatibility and correct handling for various Git hosting services.
Highlights
- Repository Type Detection: I've updated the logic for determining the repository type (
repoType
) to first attempt to infer it from therepoUrl
by checking for common domain names likebitbucket.org
,gitlab.com
, andgithub.com
. This ensures that the correct repository type is recognized automatically when arepoUrl
is provided. - Fallback Mechanism: The previous method of relying solely on the
type
search parameter, defaulting togithub
, is now used only as a fallback if the repository type cannot be determined from therepoUrl
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes the logic to detect the repository type from the URL. The review suggests improving the robustness of the detection logic and using a more concise coding style.
src/app/[owner]/[repo]/page.tsx
Outdated
if (repoUrl?.includes('bitbucket.org')) repoType = 'bitbucket'; | ||
else if (repoUrl?.includes('gitlab.com')) repoType = 'gitlab'; | ||
else if (repoUrl?.includes('github.com')) repoType = 'github'; | ||
else repoType = searchParams.get('type') || 'github'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a more robust approach to determine the repository type by parsing the URL and inspecting the hostname
instead of relying on String.prototype.includes()
on the entire URL. This prevents misidentification in cases where the URL might contain substrings like bitbucket.org
in the query parameters. Also, the let
keyword can be avoided by using a ternary operator.
const repoType = repoUrl?.includes('bitbucket.org')
? 'bitbucket'
: repoUrl?.includes('gitlab.com')
? 'gitlab'
: repoUrl?.includes('github.com')
? 'github'
: searchParams.get('type') || 'github';
In this PR I provide fix support for bitbucket and gitlab repository links.
repoType was chosen based on GET param which is "github" by default.

This GET param is changed only when "access token" section repository type is selected, but UI suggest that it's recognized automatically.
therefore when using suggested link for open bitbucket repository (https://bitbucket.org/atlassian/atlaskit) it end with 404 error message that comes from github related condition
Changed code to detect repository type from URL in first place.