Dimensional depth and time in heat conduction equation #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 93.97% 93.94% -0.04%
==========================================
Files 11 11
Lines 681 677 -4
==========================================
- Hits 640 636 -4
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Move `broadcast_thermo_params!` function into the `SingleTPM` constructor.
Introduce `thermal_conductivity`, `density`, and `heat_capacity` instead of `period`, `skindepth`, and `inertia`.
Make time `t` and depth `z` dimensional in units of [s] and [m] to solve the heat conduction equation.
Remove `E_cons` from `SingleTPMResult` because `period` was removed from `ThermoParams`.
Bugfix
Remove `E_cons` calculation
MasanoriKanamaru
force-pushed
the
feature/dimensional-depth-time
branch
from
99beec9 to
d8e4d63
Compare
Show energy output/input ratio at the current time step at the progress bar. The average energy balance over a rotation period was displayed in previous versions. Because the rotation period has been removed from ThermoParams with this PR, I have decided to display the energy balance for each time step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThermoParamscontains thermal conductivity, density, and heat capacity to solve a heat conduction equation, instead of rotation period, thermal inertia, and thermal skin depth. With this PR, timetand depthzare treated as quantities with dimensions ([s] and [m], respectively).