-
-
Notifications
You must be signed in to change notification settings - Fork 269
fix(lua): skip selene install on aarch64 platforms #1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
selene is not compatible with aarch64 (e.g., Raspberry Pi 5). This adds architecture detection to avoid installing selene where unsupported, while preserving all other functionality. This prevents startup errors and failed installs.
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
Selene actually supports and releases arm64/aarch64 binaries. Is it an issue with mason perhaps? |
Yeah, when the Lua pack is enabled, Mason does not like it.
I used to have a workaround in mason.lua, but because a lot has changed recently in Mason and Nvim 0.11, my workaround does not work anymore. |
lets try and upstream it to mason instead. What does the mason logs say? |
|
I went ahead and upstreamed it directly to Mason with a fix, as suggested. |
selene is not compatible with aarch64 (e.g., Raspberry Pi 5). This adds architecture detection to avoid installing selene where unsupported, while preserving all other functionality. This prevents constant failed installs on Nvim start when using Lua pack.
📑 Description
This pull request introduces conditional support for the
selene
linter based on the system architecture, specifically excluding it onaarch64
systems. It also refactors related configurations to ensure compatibility and maintainability.Conditional
selene
Support:aarch64
) usingvim.loop.os_uname().machine
and stored the result in a newis_aarch64
variable. (lua/astrocommunity/pack/lua/init.lua
, lua/astrocommunity/pack/lua/init.luaR5-R22)mason-null-ls.nvim
andmason-tool-installer.nvim
configurations to conditionally includeselene
in theensure_installed
list only if not onaarch64
. (lua/astrocommunity/pack/lua/init.lua
, lua/astrocommunity/pack/lua/init.luaL35-R77)nvim-lint
configuration to excludeselene
fromlinters_by_ft
andlinters
onaarch64
systems. (lua/astrocommunity/pack/lua/init.lua
, lua/astrocommunity/pack/lua/init.luaL67-R105)