-
-
Notifications
You must be signed in to change notification settings - Fork 273
feat(completion): Add in codex.nvim #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
Yeah, would be good idea to add the author. It's already confusing with copilot.nvim and copilot.vim for some people 😄 |
There is still some work to be done yet on the plugin, planning on pushing out some tests today and checking compliance with the neovim spec. |
Update: Plugin is finalized and ready for release Plugin has also been updated with an auto-install flag, which will auto install codex via npm if not available. Otherwise it will notify the user and ask them to run the command Depending on how hands-off we want the default config to be for the user, I would recommend setting The default plugin configuration is as follows, all can be overridden with the opts table in the plugin setup call as shown in the plugin repo opts = {
keymaps = {}, -- disable internal mapping
border = 'rounded', -- or 'double'
width = 0.8,
height = 0.8,
autoinstall = true,
} |
This might be one of the case where we need to prefix the author to the name, since I recon it could be a flood of codex.nvim plugins. WDYT? @AstroNvim/astrocommunity-maintainers