Skip to content

feat(completion): Add in codex.nvim #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(completion): Add in codex.nvim #1453

wants to merge 2 commits into from

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Apr 18, 2025

This might be one of the case where we need to prefix the author to the name, since I recon it could be a flood of codex.nvim plugins. WDYT? @AstroNvim/astrocommunity-maintainers

@Uzaaft Uzaaft requested a review from a team April 18, 2025 11:02
Copy link

github-actions bot commented Apr 18, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@azdanov
Copy link
Contributor

azdanov commented Apr 18, 2025

Yeah, would be good idea to add the author. It's already confusing with copilot.nvim and copilot.vim for some people 😄

@johnseth97
Copy link

There is still some work to be done yet on the plugin, planning on pushing out some tests today and checking compliance with the neovim spec.

@Uzaaft Uzaaft marked this pull request as draft April 18, 2025 20:10
@Uzaaft Uzaaft marked this pull request as ready for review April 19, 2025 08:01
@johnseth97
Copy link

johnseth97 commented Apr 20, 2025

Update: Plugin is finalized and ready for release

Plugin has also been updated with an auto-install flag, which will auto install codex via npm if not available. Otherwise it will notify the user and ask them to run the command npm i -g codex, as the default behavior. Codex will notify the user if they need to set $OPENAI_API_KEY env.

Depending on how hands-off we want the default config to be for the user, I would recommend setting autoinstall=true in the opts table

The default plugin configuration is as follows, all can be overridden with the opts table in the plugin setup call as shown in the plugin repo

opts = {
    keymaps = {}, -- disable internal mapping
    border = 'rounded', -- or 'double'
    width = 0.8,
    height = 0.8,
    autoinstall = true,
  }

@Uzaaft Uzaaft marked this pull request as draft April 24, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants