Skip to content

feat(edgy-nvim)!: Remove <Leader>f mapping from community plugin #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025

Conversation

shivanthzen
Copy link
Contributor

@shivanthzen shivanthzen commented Apr 6, 2025

📑 Description

f is prefix for all picker actions.
The keymaps for edgy overlaps with this. Remapping the keybindings for edgy

ℹ Additional Information

@shivanthzen shivanthzen marked this pull request as draft April 6, 2025 13:54
Copy link

github-actions bot commented Apr 6, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@shivanthzen shivanthzen changed the title Remove <Leader>f mapping from community plugin feat: Remove <Leader>f mapping from community plugin Apr 7, 2025
@azdanov
Copy link
Contributor

azdanov commented Apr 8, 2025

What is the reason to remove it? It conflicts with an existing mapping?

@ButterSus
Copy link
Contributor

ButterSus commented Apr 14, 2025

.image

<leader>f is prefix for all picker actions.
It actually overlaps. Wouldn't it be better to remap it? <leader>ue for example.
<leader>ue and <leader>uE are not mentioned in astrocommunity/

@Uzaaft
Copy link
Member

Uzaaft commented Apr 25, 2025

Any updates on this? @shivanthzen

@shivanthzen shivanthzen marked this pull request as ready for review April 29, 2025 18:45
@shivanthzen shivanthzen changed the title feat: Remove <Leader>f mapping from community plugin feat(split-and-window): Remove <Leader>f mapping from community plugin Apr 30, 2025
@shivanthzen
Copy link
Contributor Author

@Uzaaft

@Uzaaft
Copy link
Member

Uzaaft commented Apr 30, 2025

Answer the question that azdanov asked @shivanthzen before pinging me...

@shivanthzen
Copy link
Contributor Author

shivanthzen commented Apr 30, 2025

<leader>f is prefix for all picker actions.
It actually overlaps. Wouldn't it be better to remap it? <leader>ue for example.
<leader>ue and <leader>uE are not mentioned in astrocommunity/

Already answered here

@azdanov azdanov changed the title feat(split-and-window): Remove <Leader>f mapping from community plugin feat(edgy-nvim)!: Remove <Leader>f mapping from community plugin May 1, 2025
@azdanov
Copy link
Contributor

azdanov commented May 1, 2025

Looks good. Thanks! @Uzaaft what do you think? Seems like a breaking change, so I updated the title accordingly.

@azdanov azdanov merged commit 3077baa into AstroNvim:main May 2, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants