fix: allow context.span_id as column name in pandas dataframe
#7368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
mikeldking
force-pushed
the
feat/annotations
branch
2 times, most recently
from
0750554 to
beb1c9c
Compare
dosubot
bot
added
size:XXL
RogerHYang
force-pushed
the
allow-context-span-id-as-column-name
branch
from
59873b5 to
95674c6
Compare
dosubot
bot
added
size:L
mikeldking
approved these changes
May 11, 2025
Comment on lines
+635
to
+636
| and not all(isinstance(x, str) for x in dataframe.index) # pyright: ignore[reportUnknownVariableType,reportUnknownMemberType] | ||
| ): |
There was a problem hiding this comment.
pyright ignore? Do we need pyright here?
There was a problem hiding this comment.
pyright is used here for type checking TypedDict (so they would work somewhat like js). Unfortunately it means we need to ignore it every time we use pandas because pandas types are very lax.
GeLi2001
pushed a commit
that referenced
this pull request
May 21, 2025
RogerHYang
added a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
context.span_idin annotations DataFrame validationChanges
context.span_idcolumn as an alternative tospan_idin DataFrame validationspan_idandcontext.span_idcolumns from being present simultaneouslycontext.span_idfunctionalityTesting
context.span_idcolumncontext.span_id