feat(admin): users REST api #7314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
commit: |
|
waiting for #7349 |
mikeldking
force-pushed
the
mikeldking/user-api
branch
from
eeac931 to
0650cfe
Compare
dosubot
bot
added
size:XL
RogerHYang
reviewed
Apr 30, 2025
RogerHYang
reviewed
Apr 30, 2025
RogerHYang
reviewed
Apr 30, 2025
RogerHYang
reviewed
Apr 30, 2025
RogerHYang
reviewed
Apr 30, 2025
RogerHYang
reviewed
Apr 30, 2025
RogerHYang
reviewed
Apr 30, 2025
…taframe` to client (#7071) * Initial implementation of spans module for client * Update client implementation to not use pydantic * Ensure interface consistency * Add more consistency tests * Update test requirements * Clean up typing issues * Remove needless comments * Some linting * Ruff 🐶 * Add pandas stubs * Remove needless comments * Do not require pandas to export spans * Ruff 🐶 * Add pandas type stubs * Remove optional dependencies * Use correct endpoints * Remove from_dict * Add separate dataframe methods for clients * Delay pandas import * Update sync client * Dynamically update client classes * Create new test client fixture * Update spans handler * Update imports * Update async spans handler * More client cleanup * A query is optional * Correctly put queries into a list * Remove phoenix import * Ensure that output is set * xfail until spans is released * Ruff 🐶 * Update xfail condition * xfail correct test * Pywright cannot resolve pandas attributes * override unused-ignore * Vendor datetime util * Add helper method to process multipart response * Ruff 🐶 * Require kwarg invocations * Address feedback * Simplify dictionary construction * Attempt to import before making a request * Remove unused type: ignores * Tweak ignores * Assign module to dummy var * Ruff 🐶
* feat(ui): add mcp, gemini, agno integrations * add typescript
* Update chatbot_with_human_feedback.ipynb * Bump for retrigger
* chore: Clean up tsconfig * chore: Sort auto-completion suggestions in IDEs
* feat(ts): experiments * add async * feat: add concurrency support to experiment runner and update dependencies - Introduced concurrency parameter for running experiments and evaluations in parallel. - Removed repetitions parameter from experiment configuration. - Added async and @types/async dependency for improved async handling. * changeset --------- Co-authored-by: Tony Powell <apowell@arize.com>
* feat(api): expose experiment routes * feat(api): expose experiment runs * feat(api): expose the right types
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat(dashboards): rudamentary routes for dashboards * Update app/src/pages/dashboards/DashboardsPage.tsx Co-authored-by: Tony Powell <apowell@arize.com> --------- Co-authored-by: Tony Powell <apowell@arize.com>
dosubot
bot
added
size:XXL
mikeldking
commented
May 27, 2025
packages/phoenix-client/src/phoenix/client/resources/users/__init__.py
Outdated
Show resolved
Hide resolved
RogerHYang
reviewed
May 27, 2025
Comment on lines
-120
to
+121
| user_role=enums.UserRole.MEMBER, | ||
| user_role="ADMIN" if user.is_admin else "MEMBER", |
There was a problem hiding this comment.
This seems to be bug. On the other hand if we're not checking the db for admin status every time, we'll need to ensure that our token attribute cache is updating correctly and in robust and timely ways.
mikeldking
commented
May 27, 2025
packages/phoenix-client/src/phoenix/client/resources/users/__init__.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7313
Adds the ability to list, create, and delete users.
Testing
The testing is entirely manual as tests for REST run unauthenticated.