feat(annotations): Summarize annotations on spans, tables, project header #7247
Conversation
| @@ -30,8 +30,6 @@ export const ContinuousAnnotationInput = forwardRef< | |||
| }, | |||
| ref | |||
| ) => { | |||
| // step should be 1 if the min and max end in .0, .1 otherwise | |||
| const step = (annotationConfig?.lowerBound ?? 0) % 1 === 0 ? 1 : 0.1; | |||
There was a problem hiding this comment.
This actually prevents users from typing in non-stepped values, not sure why I thought otherwise. Maybe its a react aria behavior
| @@ -52,6 +52,7 @@ export function SpanAnnotationActionMenu(props: SpanAnnotationActionMenuProps) { | |||
| node(id: $spanId) { | |||
| ... on Span { | |||
| ...SpanAnnotationsEditor_spanAnnotations | |||
| ...SpanFeedback_annotations | |||
There was a problem hiding this comment.
This makes the span feedback table reload when annotations are deleted
| @@ -281,6 +281,7 @@ function SpanAnnotationsList(props: { | |||
| query { | |||
| node(id: $spanId) { | |||
| ... on Span { | |||
| ...TraceHeaderRootSpanAnnotationsFragment | |||
There was a problem hiding this comment.
reload stats on the trace details slideover when annotations are mutated
cephalization
force-pushed
the
cephalization/annotations/7002-annotation-summary
branch
from
80a1c79 to
88e8ea0
Compare
dosubot
bot
added
the
size:XXL
cephalization
force-pushed
the
cephalization/annotations/7002-annotation-summary
branch
from
ecb3cee to
e57d853
Compare
cephalization
force-pushed
the
cephalization/annotations/7002-annotation-summary
branch
from
d9c3040 to
e073b94
Compare
Additionally improve representation of mean annotation score, and long annotation names.
The spacing in the TraceHeader should be even here.
|
| /** Override clickable detection. By default, clickable will only be true if onClick is provided. */ | ||
| clickable?: boolean; | ||
| /** Whether to show the click affordance icon when clickable is true. */ | ||
| showClickableIcon?: boolean; |
There was a problem hiding this comment.
this feels really confusing. I don't get this permutation
There was a problem hiding this comment.
I was trying to add more customization to this component while keeping it backwards compatible, since it is used in a bunch of places.
I updated the comments to be clearer about their intention
| span: AnnotationSummaryGroup$key; | ||
| showFilterActions?: boolean; | ||
| renderEmptyState?: () => React.ReactNode; | ||
| variant?: "stacked" | "pills"; |
There was a problem hiding this comment.
Just a gut reaction this feels a bit overloaded - I get that they are the same thing sorta but it's a bit tough since I would never advise to add another variant here and there's other sizing constraints.
There was a problem hiding this comment.
I've split this up into multiple components with a shared hook
- Split AnnotationSummaryGroup into two components with shared hook - Tweak padding - Remove Pie chart from annotation token
cephalization
deleted the
cephalization/annotations/7002-annotation-summary
branch
Resolves #7002