feat(js-bedrock-agent-runtime): AWS Bedrock Agent Instumentaion for JS #1874

satyadevai · 2025-07-16T19:30:54Z

No description provided.

pkg-pr-new · 2025-07-20T09:49:56Z

@arizeai/openinference-core

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-core@1874

@arizeai/openinference-instrumentation-bedrock-agent-runtime

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-bedrock-agent-runtime@1874

@arizeai/openinference-instrumentation-beeai

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-beeai@1874

@arizeai/openinference-instrumentation-langchain

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-langchain@1874

@arizeai/openinference-instrumentation-mcp

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-mcp@1874

@arizeai/openinference-instrumentation-openai

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-openai@1874

@arizeai/openinference-mastra

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-mastra@1874

@arizeai/openinference-semantic-conventions

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-semantic-conventions@1874

@arizeai/openinference-vercel

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-vercel@1874

commit: d9527b2

cursor

Bug: Instrumentation Reliability and Linting Cleanup

The instrumentation uses a fragile command.constructor.name check to identify InvokeAgentCommand instances, which is unreliable due to minification or library changes and could lead to instrumentation failures. This should be replaced with instanceof or duck typing. Additionally, an unnecessary /* eslint-disable @typescript-eslint/no-this-alias */ comment is present after the this alias is no longer in scope and should be removed.

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/instrumentation.ts#L99-L106

openinference/js/packages/openinference-instrumentation-bedrock-agent-runtime/src/instrumentation.ts

Lines 99 to 106 in 628fb30

    
           ) => { 
        
             /* eslint-disable @typescript-eslint/no-this-alias */ 
        
             const instrumentationInstance = this; 
        
             return function patchedSend( 
        
               this: typeof bedrockModule.BedrockAgentRuntimeClient.prototype, 
        
               command: InvokeAgentCommand, 
        
             ) { 
        
               if (command?.constructor?.name === "InvokeAgentCommand") {

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

js/packages/openinference-instrumentation-bedrock-agent-runtime/package.json

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/instrumentation.ts

...ackages/openinference-instrumentation-bedrock-agent-runtime/scripts/validate-invoke-agent.ts

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/response-handler.ts

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/stream-utils.ts

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/instrumentation.ts

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/response-handler.ts

Parker-Stafford · 2025-07-24T18:09:59Z

...ckages/openinference-instrumentation-bedrock-agent-runtime/examples/validate-invoke-agent.ts

+  const agentId = "<AgentId>"; // Replace with your actual agent ID
+  const agentAliasId = "<AgentAliasId>"; // Replace with your actual agent alias ID


could move to env variables and have an env.example or something, don't have to but might be more consistent with other instrumentation examples

Parker-Stafford · 2025-07-24T18:11:46Z

...ges/openinference-instrumentation-bedrock-agent-runtime/src/attributes/request-attributes.ts

+  if (requestBody.agentId) {
+    invocationParams.agentId = requestBody.agentId;
+  }
+  if (requestBody.agentAliasId) {
+    invocationParams.agentAliasId = requestBody.agentAliasId;
+  }
+  if (requestBody.sessionId) {
+    invocationParams.sessionId = requestBody.sessionId;
+  }


just curious what makes these three invocation params important here? like should we just spread the command.input into invocation params? what are we missing if we just take these three?

Parker-Stafford · 2025-07-24T18:12:09Z

...ges/openinference-instrumentation-bedrock-agent-runtime/src/attributes/request-attributes.ts

+export function extractBaseRequestAttributes(
+  command: InvokeAgentCommand,
+): Record<string, string> {
+  const attributes: Record<string, string> = {


there is an attributes type from open inference would use it

Parker-Stafford · 2025-07-24T18:12:53Z

...ges/openinference-instrumentation-bedrock-agent-runtime/src/attributes/request-attributes.ts

+  const attributes: Record<string, string> = {
+    [SemanticConventions.OPENINFERENCE_SPAN_KIND]: OpenInferenceSpanKind.LLM,
+    [SemanticConventions.LLM_SYSTEM]: "bedrock",
+    [SemanticConventions.INPUT_MIME_TYPE]: MimeType.JSON,


is this the case? looks like down below you are just adding text as the input, which would make this mimeType.text

Parker-Stafford · 2025-07-24T18:13:10Z

...ges/openinference-instrumentation-bedrock-agent-runtime/src/attributes/request-attributes.ts

+  command: InvokeAgentCommand,
+): Record<string, string> {
+  const attributes: Record<string, string> = {
+    [SemanticConventions.OPENINFERENCE_SPAN_KIND]: OpenInferenceSpanKind.LLM,


don't know enough about this package, is this not span kind of agent?

Parker-Stafford · 2025-07-24T18:31:05Z

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/instrumentation.ts

+    });
+  }
+
+  protected init(): InstrumentationModuleDefinition<unknown>[] {


i think if we type these things with the type of the BedrockModule not unknown we can simplify some of the checks and stuff dodwn below liek the getBedrockAgentModule and also provide type saftey for clients. If not possible no problem but maybe look at the openai instrumentation for how it handles these types

Parker-Stafford · 2025-07-24T18:31:51Z

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/instrumentation.ts

+          }
+          return original.apply(this, [command]);
+        };
+        /* eslint-disable @typescript-eslint/no-this-alias */


Parker-Stafford · 2025-07-24T18:33:27Z

js/packages/openinference-instrumentation-bedrock-agent-runtime/src/instrumentation.ts

+              this,
+            );
+          }
+          return original.apply(this, [command]);


just for my own understanding why is this wrapped in an array when the original type does not seem to do so?

Parker-Stafford · 2025-07-24T18:37:10Z

...entation-bedrock-agent-runtime/test/integration.instrumentation.agent-without-traces.test.ts

+  });
+
+  it("should record agent attributes and API response in span", async () => {
+    // instrumentation = create_instrumentation(memoryExporter);


Parker-Stafford · 2025-07-24T18:38:27Z

...traces-bedrockagentinstrumentation-integration-agent-attributes-and_3073832749/recording.har

+          "content": {
+            "encoding": "base64",
+            "mimeType": "application/vnd.amazon.eventstream",
+            "size": 480,


on the comment above on consuming the stream it doesn't look like any of the recordings have stream chunks is it possible to do so or no?

github-project-automation bot added this to Instrumentation Jul 16, 2025

satyadevai changed the title ~~(feat: js/bedrock-agent-runtime): Initial Commit of bedrock agent instrumentation~~ feat(js-bedrock-agent-runtime): Initial Commit of bedrock agent instrumentation Jul 16, 2025

satyadevai marked this pull request as ready for review July 20, 2025 09:45

satyadevai requested a review from a team as a code owner July 20, 2025 09:45

dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 20, 2025

This comment was marked as outdated.

Sign in to view

satyadevai force-pushed the js-bedrock-agent-instrumentation branch from 782b53b to 312e7af Compare July 20, 2025 11:32

This comment was marked as outdated.

Sign in to view

satyadevai force-pushed the js-bedrock-agent-instrumentation branch 3 times, most recently from bf034ec to 6f20bf8 Compare July 21, 2025 05:17

satyadevai changed the title ~~feat(js-bedrock-agent-runtime): Initial Commit of bedrock agent instrumentation~~ feat(js-bedrock-agent-runtime): AWS Bedrock Agent Instumentaion for JS Jul 21, 2025

satyadevai requested review from mikeldking and removed request for mikeldking July 21, 2025 16:30

satyadevai marked this pull request as draft July 21, 2025 17:00

JS AWS Bedrock Agent Runtime Instrumentation

628fb30

satyadevai force-pushed the js-bedrock-agent-instrumentation branch from 6f20bf8 to 628fb30 Compare July 21, 2025 18:20

satyadevai marked this pull request as ready for review July 21, 2025 18:51

cursor bot reviewed Jul 21, 2025

View reviewed changes

mikeldking reviewed Jul 22, 2025

View reviewed changes

caroger requested a review from Parker-Stafford July 22, 2025 16:41

dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jul 24, 2025

satyadevai force-pushed the js-bedrock-agent-instrumentation branch from 2a16d3a to fccc66c Compare July 24, 2025 07:14

Review Comments Addressed

d9527b2

satyadevai force-pushed the js-bedrock-agent-instrumentation branch from fccc66c to d9527b2 Compare July 24, 2025 07:17

satyadevai requested a review from mikeldking July 24, 2025 15:55

caroger linked an issue Jul 24, 2025 that may be closed by this pull request

🗺 [instrumentation] Amazon Bedrock Agents instrumentation (client-agent-bedrock-time) #1776

Open

Parker-Stafford reviewed Jul 24, 2025

View reviewed changes

	) => {
	/* eslint-disable @typescript-eslint/no-this-alias */
	const instrumentationInstance = this;
	return function patchedSend(
	this: typeof bedrockModule.BedrockAgentRuntimeClient.prototype,
	command: InvokeAgentCommand,
	) {
	if (command?.constructor?.name === "InvokeAgentCommand") {

		const agentId = "<AgentId>"; // Replace with your actual agent ID
		const agentAliasId = "<AgentAliasId>"; // Replace with your actual agent alias ID

feat(js-bedrock-agent-runtime): AWS Bedrock Agent Instumentaion for JS #1874

Are you sure you want to change the base?

feat(js-bedrock-agent-runtime): AWS Bedrock Agent Instumentaion for JS #1874

Uh oh!

Conversation

satyadevai commented Jul 16, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

pkg-pr-new bot commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Instrumentation Reliability and Linting Cleanup

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-new bot commented Jul 20, 2025 •

edited

Loading