feat(portkey): Add support for propmt template calls #1663
Merged
+175
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@cla-assistant check |
|
recheck |
mikeldking
approved these changes
May 22, 2025
Comment on lines
+56
to
+57
| if prompt_id := invocation_params.get("prompt_id"): | ||
| yield SpanAttributes.PROMPT_ID, prompt_id |
There was a problem hiding this comment.
I think we should put the prompt.provider here too for clarity, just put portkey in there
| @@ -53,6 +53,12 @@ def get_extra_attributes_from_request( | |||
|
|
|||
| yield SpanAttributes.LLM_INVOCATION_PARAMETERS, safe_json_dumps(invocation_params) | |||
|
|
|||
| if prompt_id := invocation_params.get("prompt_id"): | |||
| yield SpanAttributes.PROMPT_ID, prompt_id | |||
|
|
|||
There was a problem hiding this comment.
it looks like you can produce a prompt URL pretty easily if you can: https://app.portkey.ai/prompts/ecc1de52-83dc-4846-a963-8d69f86dfee3 for example
|
example prompt URL. I guess you have to parse out the URL so feel free to punt but might be nice to have a link to it. |
Aemrox
force-pushed
the
fix/port-key-prompt-id
branch
from
e1b7557 to
011a9be
Compare
added 2 commits
May 22, 2025 15:40
…per, but add functionality to place the prompt id and variables within the span attributes - tests included
Aemrox
force-pushed
the
fix/port-key-prompt-id
branch
from
011a9be to
6fb030b
Compare
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1573
If prompt_id and prompt_variables are present in the invocation params it maps them to the span attributes prompt_id and llm.prompt_template.variables. Also wraps a the Prompt.completions function in the existing completion wrapper to ensure those spans are created.
Screenshots below
