-
Notifications
You must be signed in to change notification settings - Fork 4
Config file for complex modeling artifacts conversion #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
loop: | ||
|
||
iteration_key: zone #Key on which we iterate (for a given list of zone, we want to execute a loop : for zone in list_zone) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iteration_key: zone #Key on which we iterate (for a given list of zone, we want to execute a loop : for zone in list_zone) | |
iteration_key: area #Key on which we iterate (for a given list of zone, we want to execute a loop : for zone in list_zone) |
iteration_key: zone #Key on which we iterate (for a given list of zone, we want to execute a loop : for zone in list_zone) | ||
#In the following, the notation $zone$ means the value of the string variable "zone" | ||
andromede-model: antares-historic.short-term-storage #we want to create components of such a model, with id being indexed by the iteration_key | ||
andromede-component-id : battery_$zone$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
andromede-component-id : battery_$zone$ | |
andromede-component-id : battery_$area$ |
andromede-model-parameters-to-set-a-priori: | ||
#TODO : we still have to see if the following parameters can be set a priori or have to be read in the Antares study,during the conversion. | ||
#- id: lower_rule_curve | ||
#- id: lower_rule_curve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#- id: lower_rule_curve | |
#- id: upper_rule_curve |
|
||
andromede-model-parameters-to-set-a-priori: | ||
#TODO : we still have to see if the following parameters can be set a priori or have to be read in the Antares study,during the conversion. | ||
#- id: lower_rule_curve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the current modelling of batteries with the binding constraints define lower/upper rule curves (maybe implicitly ?) ? Otherwise set lower_rule_curve
to 0 and upper-rule-curve
to 1
- id: initial_level | ||
time-dependent: false | ||
scenario-dependent: false | ||
value: -1.0 #TODO : The initial stock level constraint must be disabled or deleted in the Andromede ST storage model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it is better to write a specialized short term storage models for batteries or we can keep the current one ? And usually the initial_level
is at 0.5 ? Otherwise it may be optimized, in this case, we definitely need a different model
#TODO : we still have to see if the following parameters can be set a priori or have to be read in the Antares study,during the conversion. | ||
#- id: lower_rule_curve | ||
#- id: lower_rule_curve | ||
#- id: p_max_injection_modulation # Read in p_max_injection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be read from the availability series of thermal clusters in z_batteries
? Or the link profile between the physical area and z_batteries ?
|
||
- id : batteries_$zone$ | ||
name: batteries_$zone$ | ||
to-delete: True #This flag means that the constraint should be deleted from the Antares Study, if hybrid mode is targetted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by hybrid mode here ?
to-delete: True | ||
parameters-to-store: | ||
- id-target-andromede-model-parameter : injection_nominal_capacity | ||
location-in-legacy-study: link_capacity #TODO : find the right id to describe link capacity? @tbittar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
location-in-legacy-study: link_capacity #TODO : find the right id to describe link capacity? @tbittar | |
location-in-legacy-study: input/links/$zone$/capacities/$zone$_direct.txt |
to-delete: True | ||
parameters-to-store: | ||
- id-target-andromede-model-parameter : withdrawal_nominal_capacity | ||
location-in-legacy-study: p_max_cluster #TODO : find the right id to describe cluster pmax? @tbittar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
location-in-legacy-study: p_max_cluster #TODO : find the right id to describe cluster pmax? @tbittar | |
location-in-legacy-study: input/thermal/series/$zone$/$zone$_batteries_inj/series.txt |
to-delete: True | ||
parameters-to-store: | ||
- id-target-andromede-model-parameter : reservoir_capacity | ||
location-in-legacy-study: p_max_cluster #TODO : find the right id to describe cluster pmax? @tbittar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
location-in-legacy-study: p_max_cluster #TODO : find the right id to describe cluster pmax? @tbittar | |
location-in-legacy-study: input/thermal/series/z_batteries/z_batteries_batteries_$zone$_1/series.txt |
|
||
andromede-connection-to-create: / | ||
|
||
area-connections-to-create: #Hybrid connection to create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "hybrid" ?
antares-coupling-constraints-to-visit: | ||
|
||
- id : batteries_$zone$ | ||
name: batteries_$zone$ | ||
to-delete: True #This flag means that the constraint should be deleted from the Antares Study, if hybrid mode is targetted | ||
parameters-to-store: | ||
- id-target-andromede-model-parameter: efficiency_injection #target parameter in the andromede-model | ||
location-in-legacy-study: $zone$%z_batteries #where to read the parameter in the Antares coupling constraint | ||
multiplication-factor: -1 # The parameter we read in Antares coupling constraint should be multiplied by -1 to create target param | ||
- id-target-andromede-model-parameter: efficiency_withdrawal #there are different naming conventions between Antares CC model for batteries and the short-term storage model | ||
#=> therefore there is an intervertion between injection and withdrawal (this is no mistake) | ||
location-in-legacy-study: $zone$.$zone$_batteries_inj | ||
multiplication-factor: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of giving the Antares components to iterate through, we could specify directly the location of the Andromede model parameters :
antares-coupling-constraints-to-visit: | |
- id : batteries_$zone$ | |
name: batteries_$zone$ | |
to-delete: True #This flag means that the constraint should be deleted from the Antares Study, if hybrid mode is targetted | |
parameters-to-store: | |
- id-target-andromede-model-parameter: efficiency_injection #target parameter in the andromede-model | |
location-in-legacy-study: $zone$%z_batteries #where to read the parameter in the Antares coupling constraint | |
multiplication-factor: -1 # The parameter we read in Antares coupling constraint should be multiplied by -1 to create target param | |
- id-target-andromede-model-parameter: efficiency_withdrawal #there are different naming conventions between Antares CC model for batteries and the short-term storage model | |
#=> therefore there is an intervertion between injection and withdrawal (this is no mistake) | |
location-in-legacy-study: $zone$.$zone$_batteries_inj | |
multiplication-factor: 1 | |
- id: efficicency_injection | |
time-dependent: false | |
scenario-dependent: false | |
value: batteries_$zone$::$zone$%z_batteries | |
multiplication_factor: -1 | |
- id: efficicency_withdrawal | |
time-dependent: false | |
scenario-dependent: false | |
value: batteries_$zone$::$zone$.$zone$_batteries_inj |
And add a field a the end to list the legacy components to delete
@tbittar : I took your comments into account in a V2 file : src/andromede/input_converter/src/cc_configuration/batteries_v2.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete batteries.yaml
which is now useless and rename batteries_v2
as batteries
Generated with AI :
Human analysis : Some of these comments (but not all), may be relevant to take into account (in particular consistency accross all value files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me
This is a V1 for a configuration file structure to parametrize a future functionality of the Antares-to-Andromede converter... here in the particular case of the Antares "battery model".
There are still some "todos" :