-
Notifications
You must be signed in to change notification settings - Fork 4
Andromede V1 model validation #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a246278
Andromede V1 model validation
aoustry cf45958
Andromede V1 model validation
aoustry 1deab89
Andromede V1 model validation - response to reviwer's comments
aoustry fb1606b
Andromede V1 model validation - response to reviwer's comments
aoustry efcd922
Libraries list as fixture
aoustry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As all results file are in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
12165990 | ||
9362260 | ||
18432100 | ||
28075890 | ||
24070520 | ||
27096450 | ||
16994370 | ||
26370010 | ||
22642740 | ||
25488650 | ||
20276880 | ||
29682120 | ||
25310210 | ||
22328210 | ||
26075330 | ||
35091220 | ||
18301250 | ||
17634970 | ||
16752130 | ||
18110770 | ||
21241920 | ||
17209960 | ||
24367950 | ||
20406590 | ||
20997070 | ||
26774670 | ||
22726300 | ||
24249750 | ||
21802350 | ||
17302280 | ||
14379720 | ||
18637980 | ||
19350940 | ||
13720470 | ||
19185290 | ||
21267020 | ||
22043950 | ||
6560490 | ||
22264160 | ||
25837870 | ||
22015840 | ||
22203680 | ||
20687970 | ||
19839670 | ||
11508310 | ||
16458610 | ||
15695720 | ||
17077860 | ||
24465750 | ||
19898010 | ||
28281990 | ||
16980290 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
14515626 | ||
11517919 | ||
21459435 | ||
31698080 | ||
27486131 | ||
30729687 | ||
20018852 | ||
29925574 | ||
26034932 | ||
29049771 | ||
23581252 | ||
33395943 | ||
28809375 | ||
25512192 | ||
29520312 | ||
38887935 | ||
21412801 | ||
20747637 | ||
19650719 | ||
21074620 | ||
24562491 | ||
20145193 | ||
27811473 | ||
23568173 | ||
24323655 | ||
30143310 | ||
25987218 | ||
27619630 | ||
25018095 | ||
20346074 | ||
16949205 | ||
21744771 | ||
22381180 | ||
16704324 | ||
22320157 | ||
24475428 | ||
25307125 | ||
8805105 | ||
25360361 | ||
29243442 | ||
25162721 | ||
25438628 | ||
23859666 | ||
23177002 | ||
14352626 | ||
19632141 | ||
18495398 | ||
20067858 | ||
27778238 | ||
23232723 | ||
31939695 | ||
19773712 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
3149400 | ||
4294180 | ||
390 | ||
206760280 | ||
3386530 | ||
1805570 | ||
983410 | ||
3375850 | ||
6488930 | ||
1972740 | ||
3634000 | ||
4078100 | ||
3976720 | ||
4401760 | ||
3644390 | ||
4070410 | ||
4208230 | ||
4120890 | ||
4151280 | ||
3745210 | ||
3837300 | ||
4037030 | ||
3655330 | ||
4456190 | ||
3699400 | ||
3708610 | ||
4248330 | ||
4070820 | ||
3449380 | ||
3784720 | ||
4039450 | ||
4046050 | ||
3813210 | ||
4063050 | ||
4305430 | ||
4219490 | ||
4184540 | ||
4529290 | ||
3538150 | ||
3745320 | ||
3884270 | ||
3669730 | ||
4355150 | ||
3797870 | ||
3801010 | ||
4250890 | ||
4157640 | ||
3897980 | ||
4073870 | ||
4090750 | ||
3691910 | ||
4082310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
3339400 | ||
4530180 | ||
13000 | ||
13750280 | ||
3615530 | ||
1948570 | ||
1092410 | ||
3486850 | ||
2917930 | ||
2149740 | ||
3879000 | ||
4324100 | ||
4220720 | ||
4665760 | ||
3889390 | ||
4326410 | ||
4468230 | ||
4371890 | ||
4410280 | ||
3983210 | ||
4082300 | ||
4286030 | ||
3895330 | ||
4715190 | ||
3946400 | ||
3953610 | ||
4506330 | ||
4318820 | ||
3686380 | ||
4036720 | ||
4290450 | ||
4297050 | ||
4070210 | ||
4319050 | ||
4552430 | ||
4478490 | ||
4441540 | ||
4790290 | ||
3784150 | ||
3986320 | ||
4131270 | ||
3921730 | ||
4619150 | ||
4044870 | ||
4049010 | ||
4507890 | ||
4412640 | ||
4149980 | ||
4318870 | ||
4340750 | ||
3935910 | ||
4340310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
13360209 | ||
10451815 | ||
19926538 | ||
29875650 | ||
25771586 | ||
28887207 | ||
18485296 | ||
28118103 | ||
24301493 | ||
27237983 | ||
21900191 | ||
31509626 | ||
27041690 | ||
23894547 | ||
27770185 | ||
36961982 | ||
19828961 | ||
19137703 | ||
18185064 | ||
19562418 | ||
22871152 | ||
18651962 | ||
26042049 | ||
21938693 | ||
22615431 | ||
28415931 | ||
24318894 | ||
25905336 | ||
23363541 | ||
18781925 | ||
15652113 | ||
20138262 | ||
20839329 | ||
15144421 | ||
20690080 | ||
22834824 | ||
23630397 | ||
7628400 | ||
23792174 | ||
27482814 | ||
23555205 | ||
23786686 | ||
22253238 | ||
21448618 | ||
12887428 | ||
18001627 | ||
17069702 | ||
18542748 | ||
26104969 | ||
21522887 | ||
30075346 | ||
18349907 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
13466443 | ||
10557215 | ||
20036274 | ||
29998361 | ||
25885059 | ||
29006373 | ||
18593074 | ||
28232472 | ||
24411273 | ||
27351751 | ||
22009401 | ||
31627749 | ||
27155503 | ||
24008727 | ||
27881604 | ||
37096086 | ||
19933944 | ||
19243312 | ||
18291778 | ||
19666358 | ||
22981558 | ||
18759239 | ||
26152393 | ||
22044818 | ||
22723751 | ||
28523600 | ||
24425092 | ||
26015201 | ||
23468262 | ||
18884987 | ||
15756053 | ||
20241785 | ||
20942226 | ||
15247000 | ||
20793186 | ||
22939551 | ||
23735074 | ||
7730880 | ||
23897608 | ||
27591343 | ||
23661509 | ||
23891789 | ||
22359319 | ||
21556521 | ||
12990432 | ||
18106610 | ||
17175574 | ||
18646532 | ||
26216858 | ||
21633025 | ||
30195137 | ||
18458227 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need a time and scenario-dependent efficiency for the electrolyzer ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for the moment, I changed this.