Add st storage to input converter w tests #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
killian-scalian
commented
Apr 10, 2025
killian-scalian
commented
- Add st storage to yaml converter
- Add tests
tbittar
reviewed
Apr 10, 2025
| scenario_dependent=True, | ||
| value=str(lower_rule_curve_path), | ||
| ), | ||
| InputComponentParameter( |
There was a problem hiding this comment.
Pour la lisibilité, c'est mieux de mettre lower/upper rule curve à la suite
tbittar
reviewed
Apr 10, 2025
tests/input_converter/conftest.py
Outdated
| @@ -139,7 +140,22 @@ def actual_renewable_list_ini(local_study_with_renewable) -> IniFile: | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def local_study_with_st_storage(local_study_with_renewable) -> Study: | |||
| def default_thermal_cluster_properties() -> STStorageProperties: | |||
There was a problem hiding this comment.
Renommer la fonction default_storage_properties
tbittar
reviewed
Apr 10, 2025
| storage_connections, | ||
| ) = converter._convert_st_storage_to_component_list(areas, lib_id) | ||
|
|
||
| inflows_path = ( |
There was a problem hiding this comment.
Tu pourrais introduire une variable pour stocker study_path / "input" / "st-storage" / "series" / "fr" / "battery" et éviter de le répéter
tbittar
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.