Contrib input_converter - update battery #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killian-scalian
force-pushed
the
contrib_input_converter_battery_config
branch
from
cba7cd5 to
116334e
Compare
tbittar
reviewed
May 28, 2025
| data: | ||
| path: input/thermal/series/z_batteries/z_batteries_batteries_${area}_1/series.txt | ||
| area: z_batteries | ||
| cluster: z_batteries_batteries_${area}_1 |
There was a problem hiding this comment.
Ajouter field: series , l'idée étant d'appeler la fonction get_series_matrix d4antaresCraft derrière
There was a problem hiding this comment.
Field added
| path: input/links/${area}/capacities/z_batteries_direct.txt | ||
| area_from: ${area} | ||
| area_to: z_batteries | ||
| field: capacity_direct # peut etre properties ou capacity_indirect |
There was a problem hiding this comment.
C'est bien capacity_direct
| path: input/links/${area}/capacities/z_batteries_parameters | ||
| area_from: ${area} | ||
| area_to: z_batteries | ||
| field: parameters |
There was a problem hiding this comment.
On pourrait mettre timeseries_file_type: link_parameters ou field: link_parameters
There was a problem hiding this comment.
On sait déja que ce sont des parametres de link car cest de "type" link?
tbittar
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.