Skip to content

set httpx minver as raise for status does not return resp for httpx<0.25 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

set httpx minver as raise for status does not return resp for httpx<0.25 #15

merged 1 commit into from
May 1, 2025

Conversation

RensDimmendaal
Copy link
Contributor

This PR addresses the edge case where an old version of httpx breaks the plash_login flow as raise_for_status does not return the original request.

@RensDimmendaal RensDimmendaal requested a review from ncoop57 April 30, 2025 10:45
@RensDimmendaal RensDimmendaal changed the title set httpx minver as raise for status does not return resp for httpx<0.23 set httpx minver as raise for status does not return resp for httpx<0.24 Apr 30, 2025
@RensDimmendaal RensDimmendaal changed the title set httpx minver as raise for status does not return resp for httpx<0.24 set httpx minver as raise for status does not return resp for httpx<0.25 Apr 30, 2025
@ncoop57 ncoop57 merged commit f34a267 into main May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoop57 ncoop57 Awaiting requested review from ncoop57

Assignees

@RensDimmendaal RensDimmendaal

@KeremTurgutlu KeremTurgutlu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RensDimmendaal @ncoop57 @KeremTurgutlu