Skip to content

Conversation

RensDimmendaal
Copy link
Contributor

@RensDimmendaal RensDimmendaal commented Oct 10, 2025

Note: I've removed python 3.9 from the testing matrix as it threw an error that fastcore requires >=3.10.

After this PR running nbdev_release_gh will check if the version has been bumped.
This will avoid the annoying issue of having a duplicate version number in the changelog and committing this accidentally.

Here's what it looks like when you get the error:

$ nbdev_release_gh
Error: Version bump required: expected: >0.0.3, got: 0.0.3.

@RensDimmendaal RensDimmendaal force-pushed the check-version-before-changelog branch from fd84f9a to b44f99f Compare October 10, 2025 14:50
@RensDimmendaal RensDimmendaal requested a review from jph00 October 10, 2025 14:51
@jph00 jph00 added the enhancement New feature or request label Oct 12, 2025
@jph00
Copy link
Contributor

jph00 commented Oct 12, 2025

Thanks @RensDimmendaal :)

@jph00 jph00 merged commit 7eacee6 into main Oct 12, 2025
8 checks passed
@jph00 jph00 deleted the check-version-before-changelog branch October 12, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants