check version before changelog #1535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I've removed python 3.9 from the testing matrix as it threw an error that
fastcore
requires>=3.10
.After this PR running
nbdev_release_gh
will check if the version has been bumped.This will avoid the annoying issue of having a duplicate version number in the changelog and committing this accidentally.
Here's what it looks like when you get the error:
$ nbdev_release_gh Error: Version bump required: expected: >0.0.3, got: 0.0.3.