Skip to content

Update package build process and add 'build' to requirements #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nbdev/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def release_pypi(
):
"Create and upload Python package to PyPI"
_dir = get_config().lib_path.parent
system(f'cd {_dir} && rm -rf dist build && python setup.py sdist bdist_wheel')
system(f'cd {_dir} && rm -rf dist build && python -m build')
system(f'twine upload --repository {repository} {_dir}/dist/*')

# %% ../nbs/api/18_release.ipynb
Expand Down
2 changes: 1 addition & 1 deletion nbs/api/18_release.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@
"):\n",
" \"Create and upload Python package to PyPI\"\n",
" _dir = get_config().lib_path.parent\n",
" system(f'cd {_dir} && rm -rf dist build && python setup.py sdist bdist_wheel')\n",
" system(f'cd {_dir} && rm -rf dist build && python -m build')\n",
" system(f'twine upload --repository {repository} {_dir}/dist/*')"
]
},
Expand Down
2 changes: 1 addition & 1 deletion settings.ini
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ language = English
custom_sidebar = True
license = apache2
status = 5
requirements = fastcore>=1.8.0 execnb>=0.1.12 astunparse ghapi>=1.0.3 watchdog asttokens setuptools
requirements = fastcore>=1.8.0 execnb>=0.1.12 astunparse ghapi>=1.0.3 watchdog asttokens setuptools build
pip_requirements = PyYAML
conda_requirements = pyyaml
conda_user = fastai
Expand Down