Skip to content

fixes #1405 #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2024
Merged

fixes #1405 #1406

merged 4 commits into from
Apr 26, 2024

Conversation

deven367
Copy link
Contributor

This PR fixes the broken link in the jupyter-git blog.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@deven367
Copy link
Contributor Author

Hi @jph00, I'm not sure why runners are failing, I think GH has internally removed the Intel-based runners for macos? I may be wrong? Any thoughts?

@jph00
Copy link
Contributor

jph00 commented Apr 26, 2024

Ah looks like 3.7 isn't supported any more. I just removed it. Can you merge in my change from master?

@deven367
Copy link
Contributor Author

@jph00 I just merged from the master.

In a different PR, should I also remove 3.7 from the py_versions?
https://github.com/fastai/nbdev/blob/153f2f6a6b55a29b295affbf8d9dd9844d66a169/setup.py#L29

@jph00 jph00 merged commit b0315d1 into AnswerDotAI:master Apr 26, 2024
8 checks passed
@jph00
Copy link
Contributor

jph00 commented Apr 26, 2024

Many thanks. I don't think we need to update setup.py since the lib still works fine -- it's just not in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants