Skip to content

adv_app.py: Use 'db-namespace' style approach #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pydanny
Copy link
Collaborator

@pydanny pydanny commented May 9, 2025


name: Pull Request
about: Propose changes to the codebase
title: '[PR] Use 'db-namespace' style approach'
labels: 'cleanup,documentation'
assignees: 'pydanny'


Proposed Changes

We have seen people use attachment of tables to the database object as a way to have a 'namespace'. This way we can have db.todos represent the table and todos as a variable or function without collision.

While use of db.t for introspection is useful to know, this is documented in fastlite here.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

@pydanny pydanny self-assigned this May 9, 2025
@pydanny pydanny added documentation Improvements or additions to documentation cleanup minor code improvements that don't impact existing functionality labels May 9, 2025
@pydanny pydanny marked this pull request as ready for review May 9, 2025 00:35
@pydanny pydanny closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup minor code improvements that don't impact existing functionality documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant