Skip to content

Move dispatch and transform modules to fasttransform #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 18, 2025

Conversation

RensDimmendaal
Copy link
Contributor

@RensDimmendaal RensDimmendaal commented Mar 3, 2025

This PR can't be merged before the nbdev PR has been merged.

This PR removes the fastcore.dispatch and fastcore.transform modules as they have bent extracted to a separate repository: fasttransform.

Open questions for Jeremy:

  • verify: is the update to version 1.8.0 sufficient or should it go to 2.0.0? (1.8.0 is minimum to not break latest fastai release as it pinned: fastcore>=1.5.29,<1.8)
  • verify: get_source_link in xtras.py has been updated to be compatible w plum, but we don't add plum as a dependency to fastcore as we want to keep fastcore dependency free. Shall we add a test and add plum as a dev dependency though?
  • ./fastcore/_nbdev.py still has references to the old nbs, not sure why it isnt updated. Is it still used? Last change in that file is 3y ago.
  • update CHANGELOG.MD

@jph00 jph00 self-requested a review March 17, 2025 22:21
@jph00 jph00 added the enhancement New feature or request label Mar 17, 2025
@jph00
Copy link
Contributor

jph00 commented Mar 17, 2025

  • verify: is the update to version 1.8.0 sufficient or should it go to 2.0.0? (1.8.0 is minimum to not break latest fastai release as it pinned: fastcore>=1.5.29,<1.8)

I'm happy to use 1.8.0 if you think that'll work ok.

  • verify: get_source_link in xtras.py has been updated to be compatible w plum, but we don't add plum as a dependency to fastcore as we want to keep fastcore dependency free. Shall we add a test and add plum as a dev dependency though?

Adding a test and dev dep could be a future PR if we wanted.

  • ./fastcore/_nbdev.py still has references to the old nbs, not sure why it isnt updated. Is it still used? Last change in that file is 3y ago.

I guess not - could be a future PR.

  • update CHANGELOG.MD

That's handled automatically.

@RensDimmendaal let me know if you think this is ready to merge.

@jph00 jph00 closed this Mar 17, 2025
@jph00 jph00 reopened this Mar 17, 2025
@jph00
Copy link
Contributor

jph00 commented Mar 18, 2025

All tests are now passing except the fastai integration tests (which will of course require the fastai PR, so we can ignore them here).

@jph00 jph00 marked this pull request as ready for review March 18, 2025 05:15
@jph00 jph00 merged commit b74cfce into main Mar 18, 2025
9 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants