generated from fastai/nbdev_template
-
Notifications
You must be signed in to change notification settings - Fork 288
Move dispatch and transform modules to fasttransform #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2025
2 tasks
I'm happy to use 1.8.0 if you think that'll work ok.
Adding a test and dev dep could be a future PR if we wanted.
I guess not - could be a future PR.
That's handled automatically. @RensDimmendaal let me know if you think this is ready to merge. |
All tests are now passing except the fastai integration tests (which will of course require the fastai PR, so we can ignore them here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can't be merged before the nbdev PR has been merged.
This PR removes the
fastcore.dispatch
andfastcore.transform
modules as they have bent extracted to a separate repository:fasttransform
.Open questions for Jeremy:
fastcore>=1.5.29,<1.8
)get_source_link
inxtras.py
has been updated to be compatible w plum, but we don't add plum as a dependency to fastcore as we want to keep fastcore dependency free. Shall we add a test and add plum as a dev dependency though?./fastcore/_nbdev.py
still has references to the old nbs, not sure why it isnt updated. Is it still used? Last change in that file is 3y ago.