Add sort args to delegates #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pydanny
force-pushed
the
add-sort-args-to-delegates
branch
from
5256529 to
79780eb
Compare
pydanny
force-pushed
the
add-sort-args-to-delegates
branch
from
9838b7e to
765157b
Compare
Co-Authored-By: Audrey M. Roy Greenfeld <audrey@feldroy.com>
pydanny
force-pushed
the
add-sort-args-to-delegates
branch
from
765157b to
3b2af9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions that have a lot of arguments can be hard to use. When using
fastcore.script.delegatesto composite several layers of functions into one, this scenario becomes more frequent and poignant.This PR:
sort_argsparameter tofastcore.meta.delegatesthat changes the function signature to list the arguments in alphabetical ordercall_parseto benefit from this change. call_parse's use of argparse makes this a significant task, involving modifying the argparse library to notsys.exit()during use of--help. We believe correcting this is out of scope for this change, as it appears to involve using thepatchdecorator on the ArgumentParser usage incall_parse, which might break things downstream.