Skip to content

Fix undefined behaviour of: get address of argument variables #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined behaviour of: get address of argument variables #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions micro-wac/Wasmcomp.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,7 @@ let rec accessVar varEnv funEnv op = function
@ [varAssOp false lv.Type lv.Offset]
| ArgVar av -> match op with
| GetValue -> [varAccOp true av.Type av.Id]
| GetAddr -> match av.Type with
| TypP _ -> [varAccOp true av.Type av.Id]
| TypA (typ, _) -> [varAccOp true typ av.Id]
| _ -> failwith (sprintf "can't get address of non-pointer function argument %A" av)
| GetAddr -> failwith (sprintf "can't get address of function arguments %A" av)
| Set exp -> cExpr varEnv funEnv exp @ [varAssOp true av.Type av.Id]
| GloVar gv -> I32_CONST gv.Addr
:: match op with
Expand Down