Skip to content

adds board support for SparkFun Thing Plus NORAW306 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

lewispg228
Copy link
Contributor

Description of Change

  • Adds boards support for SparkFun Thing Plus NORAW306
  • Adds suggested change to SPI.begin and SPI1.begin location. It was causing runtime failures when using an WS2812B LED example that calls show() multiple times to change colors.

Tests and Environments

  • SPARKFUN_THINGPLUS_NORAW306
  • ambd_arduino V3.1.7
  • Arduino IDE 2.3.2
  • Windows 11 Pro

lewispg228 and others added 7 commits June 3, 2024 15:27
-Moved SPI.begin() out of show() and into begin().
-whne you call show multiple times to change the LED, then SPI.begin() was being called and causing it to fail.
fix for compatibility issue BOARD_AMB23, BOARD_AITHINKER_BW16
@M-ichae-l
Copy link
Contributor

M-ichae-l commented Jun 6, 2024

Let's ignore the spell check as it is not an error. If no further discussion, will process to merge by this week.

@M-ichae-l M-ichae-l merged commit 0b90ffa into Ameba-AIoT:dev Jun 10, 2024
9 of 10 checks passed
@lewispg228
Copy link
Contributor Author

@M-ichae-l Thank you for helping to merge this in so quickly!

Sorry, but I think our changes to the WS2812B show() function have introduced a new problem. Our QA team had discovered that it still gets hung up when you try to do multiple calls to "show()" method.

We think we have found the solution:

We just need to simply remove the call to spi_free() at the end of show().

image

https://github.com/ambiot/ambd_arduino/blob/dev/Arduino_package/hardware/libraries/WS2812B/src/WS2812B.cpp#L92

Let us know what you think and thanks,
Pete

@lewispg228
Copy link
Contributor Author

We moved this to a more properly documented issue here: issue #241 .

We will submit a PR with a suggested fix soon.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants