Verify the actual response from api, instead of the parsed and potentially modified response #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tally modified response
Use .ScrubMember("version") to remove the nuget version from the info section
Use Microsoft.OpenApi.Readers only to verify that the package don't have validations that break.
ivarne
added
ignore-for-release
backport-ignore
|
| return settings; | ||
| } | ||
| await VerifyJson(openApi) | ||
| .ScrubMember("version") |
There was a problem hiding this comment.
Doesn't this scrub any field called version? That sounds like something we should avoid
There was a problem hiding this comment.
Yes, but there isn't any other "version": fields in the open api spec, and if there ever was one, it would show up in the diff we accept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #1183 (comment)
Use .ScrubMember("version") to remove the nuget version from the info section
Use Microsoft.OpenApi.Readers only to verify that the package don't have validations that break.
Filter out the path parameter
{dataType}that is used in the custom swagger file to allow annotation of data type schema