-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix goroutine logic bug #7215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix goroutine logic bug #7215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
|
改成这样之后好像是1条连接2个通道同时下载,,像阿里云盘Open是1条连接限速500k左右,并不能加速下载 |
这里我只修正了逻辑给夸克驱动用,其它驱动可以加参数开启,看我仓库的提交。 |
j2rong4cn
added a commit
to j2rong4cn/alist
that referenced
this pull request
Jan 17, 2025
* Fix goroutine logic bug * Fix bug --------- Co-authored-by: hpy hs <hshpy.pengyu@gmail.com>
|
你这个PR可以取消吗?我提交了个pro max版本的 |
j2rong4cn
added a commit
to j2rong4cn/alist
that referenced
this pull request
Jan 20, 2025
commit 524267b Author: j2rong4cn <253551464@qq.com> Date: Mon Jan 20 18:54:58 2025 +0800 refactor commit f4ba815 Author: j2rong4cn <253551464@qq.com> Date: Sun Jan 19 18:16:45 2025 +0800 refactor commit 8e78e4f Author: j2rong4cn <253551464@qq.com> Date: Sat Jan 18 19:17:58 2025 +0800 pref(net): create `chunk` on demand commit d04d606 Author: j2rong4cn <253551464@qq.com> Date: Sat Jan 18 13:14:40 2025 +0800 feat(net): add `ConcurrencyLimit` commit edbc8c9 Author: j2rong4cn <253551464@qq.com> Date: Tue Jan 14 23:58:11 2025 +0800 feat(alias): add `DownloadConcurrency` and `DownloadPartSize` option commit fa65e5f Author: j2rong4cn <253551464@qq.com> Date: Fri Jan 17 18:26:43 2025 +0800 fix(net): incorrect error return commit ac03454 Author: j2rong4cn <253551464@qq.com> Date: Fri Jan 17 18:24:36 2025 +0800 perf(net): sequential and dynamic concurrency commit 866fe8d Author: j2rong4cn <253551464@qq.com> Date: Tue Dec 31 00:31:30 2024 +0800 fix(net): goroutine logic bug (AlistGo#7215) * Fix goroutine logic bug * Fix bug --------- Co-authored-by: hpy hs <hshpy.pengyu@gmail.com>
j2rong4cn
added a commit
to j2rong4cn/alist
that referenced
this pull request
Jan 21, 2025
commit f2ce10c Author: j2rong4cn <253551464@qq.com> Date: Wed Jan 22 04:08:58 2025 +0800 refactor commit f7bcacb Author: j2rong4cn <253551464@qq.com> Date: Tue Jan 21 19:08:37 2025 +0800 fix(net): `r.Closers.Add` has no effect commit 524267b Author: j2rong4cn <253551464@qq.com> Date: Mon Jan 20 18:54:58 2025 +0800 refactor commit f4ba815 Author: j2rong4cn <253551464@qq.com> Date: Sun Jan 19 18:16:45 2025 +0800 refactor commit 8e78e4f Author: j2rong4cn <253551464@qq.com> Date: Sat Jan 18 19:17:58 2025 +0800 pref(net): create `chunk` on demand commit d04d606 Author: j2rong4cn <253551464@qq.com> Date: Sat Jan 18 13:14:40 2025 +0800 feat(net): add `ConcurrencyLimit` commit edbc8c9 Author: j2rong4cn <253551464@qq.com> Date: Tue Jan 14 23:58:11 2025 +0800 feat(alias): add `DownloadConcurrency` and `DownloadPartSize` option commit fa65e5f Author: j2rong4cn <253551464@qq.com> Date: Fri Jan 17 18:26:43 2025 +0800 fix(net): incorrect error return commit ac03454 Author: j2rong4cn <253551464@qq.com> Date: Fri Jan 17 18:24:36 2025 +0800 perf(net): sequential and dynamic concurrency commit 866fe8d Author: j2rong4cn <253551464@qq.com> Date: Tue Dec 31 00:31:30 2024 +0800 fix(net): goroutine logic bug (AlistGo#7215) * Fix goroutine logic bug * Fix bug --------- Co-authored-by: hpy hs <hshpy.pengyu@gmail.com>
j2rong4cn
added a commit
to j2rong4cn/alist
that referenced
this pull request
Jan 23, 2025
* Fix goroutine logic bug * Fix bug --------- Co-authored-by: hpy hs <hshpy.pengyu@gmail.com>
j2rong4cn
added a commit
to j2rong4cn/alist
that referenced
this pull request
Jan 23, 2025
commit 97ee3f9 Author: j2rong4cn <253551464@qq.com> Date: Thu Jan 23 14:08:12 2025 +0800 refactor commit 822b1df Author: j2rong4cn <253551464@qq.com> Date: Tue Jan 21 19:08:37 2025 +0800 fix(net): `r.Closers.Add` has no effect commit 1e72e70 Author: j2rong4cn <253551464@qq.com> Date: Mon Jan 20 18:54:58 2025 +0800 refactor commit cc55294 Author: j2rong4cn <253551464@qq.com> Date: Sun Jan 19 18:16:45 2025 +0800 refactor commit 4dd8746 Author: j2rong4cn <253551464@qq.com> Date: Sat Jan 18 19:17:58 2025 +0800 pref(net): create `chunk` on demand commit 60407c3 Author: j2rong4cn <253551464@qq.com> Date: Sat Jan 18 13:14:40 2025 +0800 feat(net): add `ConcurrencyLimit` commit d5e51ce Author: j2rong4cn <253551464@qq.com> Date: Tue Jan 14 23:58:11 2025 +0800 feat(alias): add `DownloadConcurrency` and `DownloadPartSize` option commit 46bd0a7 Author: j2rong4cn <253551464@qq.com> Date: Fri Jan 17 18:26:43 2025 +0800 fix(net): incorrect error return commit 45ec9d3 Author: j2rong4cn <253551464@qq.com> Date: Fri Jan 17 18:24:36 2025 +0800 perf(net): sequential and dynamic concurrency commit 6622552 Author: j2rong4cn <253551464@qq.com> Date: Tue Dec 31 00:31:30 2024 +0800 fix(net): goroutine logic bug (AlistGo#7215) * Fix goroutine logic bug * Fix bug --------- Co-authored-by: hpy hs <hshpy.pengyu@gmail.com>
xhofe
pushed a commit
that referenced
this pull request
Jan 27, 2025
…7829) * fix(net): goroutine logic bug (#7215) * Fix goroutine logic bug * Fix bug --------- Co-authored-by: hpy hs <hshpy.pengyu@gmail.com> * perf(net): sequential and dynamic concurrency * fix(net): incorrect error return * feat(alias): add `DownloadConcurrency` and `DownloadPartSize` option * feat(net): add `ConcurrencyLimit` * pref(net): create `chunk` on demand * refactor * refactor * fix(net): `r.Closers.Add` has no effect * refactor --------- Co-authored-by: hpy hs <hshpy.pengyu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
提前返回导致后面Channel下载任务不执行