Temporarily disable unused dependencies in StockFlow.jl and Rewrite.jl #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saityi
previously requested changes
May 15, 2025
There was a problem hiding this comment.
@NSepahrom1984 These modifications should probably replace the originals rather than being added in addition to them.
I.e., StockFlow.jl should be in src/, and Rewrite.jl should be in src/syntax/ rather than the root project directory.
We should also remove AlgebraicRewriting from Project.toml. I think you may have forgotten to commit your changes to it?
As-is, StockFlow.jl (the library) still depends on AlgebraicRewriting.jl.
|
Hi @Saityi, I’ve made the requested changes:
Please let me know if anything else is needed. Thank you! |
|
Hi @Saityi, |
|
Integrated into #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes modifications
StockFlow.jlandRewrite.jlto temporarily disable dependencies and functionality that are not currently in use.AlgebraicRewritinghas been commented out inProject.tomlFinSethas been commented out inStockFlow.jlRewrite.jlhave been commented outThese changes are intended to simplify the working version of the repository for integrating new functionality without breaking the current build. The commented code can be restored as needed later.