-
Notifications
You must be signed in to change notification settings - Fork 9
Upgrade to Catlab 0.17 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Saityi
wants to merge
20
commits into
AlgebraicJulia:main
Choose a base branch
from
Saityi:gatlabified-catlab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture is maintained
5a69713
to
8d44b59
Compare
… in OpenStockAndFlow
…l_model.ipynb according to Alex new log
…:Yuge168/StockFlow.jl into gatlabified-catlab
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 60.69% 60.88% +0.19%
==========================================
Files 10 9 -1
Lines 2193 2058 -135
==========================================
- Hits 1331 1253 -78
+ Misses 862 805 -57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
n_stratify
), integrating Temporarily disable unused dependencies in StockFlow.jl and Rewrite.jl #141, which this supersedesn_stratify
is not used in any examples and appears to be primarily to make stratification easier to use. The other stratification DSL appears to still functionsrc/syntax/Stratification.jl
L334 (pullback
usage) and tests (test/syntax/Stratification.jl
,pullback
usage andis_natural
)StockAndFlow
data types no longer in useThis currently passes the unit tests and the notebook examples validate.
Notebook validation is expected to fail pending TODOsTODOs:
Update all examples inAddressed by @Yuge168examples/
to use Catlab 0.17Figure out why somen_stratify
examples work but others don't (comparechain_ltype
, which fails with an exception, andage_weight_5
(which is successfully stratified).n_stratify
has been commented out and will be revisited at some other pointFYI @ndo885 @NSepahrom1984