Skip to content

Conversation

Saityi
Copy link
Collaborator

@Saityi Saityi commented Aug 27, 2025

This PR:

  1. Disables some functionality (Rewriting, n_stratify), integrating Temporarily disable unused dependencies in StockFlow.jl and Rewrite.jl #141, which this supersedes
    • n_stratify is not used in any examples and appears to be primarily to make stratification easier to use. The other stratification DSL appears to still function
  2. Updates remaining functionality to use Catlab 0.17; examples of this include src/syntax/Stratification.jl L334 (pullback usage) and tests (test/syntax/Stratification.jl, pullback usage and is_natural)
  3. Removes old StockAndFlow data types no longer in use
  4. Deletes older examples not using the DSL
  5. Disables the Literate.jl (docs) step of CI
  6. Updates the notebook validation step to match new examples

This currently passes the unit tests and the notebook examples validate. Notebook validation is expected to fail pending TODOs

TODOs:

  1. Update all examples in examples/ to use Catlab 0.17 Addressed by @Yuge168
  2. Figure out why some n_stratify examples work but others don't (compare chain_ltype, which fails with an exception, and age_weight_5 (which is successfully stratified). n_stratify has been commented out and will be revisited at some other point

FYI @ndo885 @NSepahrom1984

@Saityi Saityi force-pushed the gatlabified-catlab branch from 5a69713 to 8d44b59 Compare August 29, 2025 00:05
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.88%. Comparing base (c6cb155) to head (d836234).
⚠️ Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
src/StockFlow.jl 16.66% 5 Missing ⚠️
src/SystemStructure.jl 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   60.69%   60.88%   +0.19%     
==========================================
  Files          10        9       -1     
  Lines        2193     2058     -135     
==========================================
- Hits         1331     1253      -78     
+ Misses        862      805      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Saityi Saityi marked this pull request as ready for review October 15, 2025 15:17
@Saityi Saityi requested a review from Xiaoyan-Li October 15, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants