removed redundant ODEProblem overload #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the modelingtoolkit extension mostly overloads ODEProblem, which we can overload without depending on modelingtoolkit. We might want to see what parts of the modelingtoolkit extension can be moved over to just the OrdinaryDiffEq extension.
|
@jpfairbanks Good to merge? |
|
This feature was here for integration with TA3 on ASKEM. We can remove it and if it breaks that integration, copy these 5 lines into their codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the modelingtoolkit extension mostly overloads ODEProblem, which we can overload without depending on modelingtoolkit.
We might want to see what parts of the modelingtoolkit extension can be moved over to just the OrdinaryDiffEq extension.