Clean up orphaned droplets #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
9 times, most recently
from
d275c80 to
88c32ab
Compare
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
5 times, most recently
from
ae4a428 to
2879a22
Compare
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
from
2879a22 to
167efb0
Compare
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
8 times, most recently
from
7c0da11 to
b3d1e5e
Compare
If a droplet is created by the autoscaler, but it fails to register with nomad as a client, it should be considered an orphan and deleted. Add a configuration setting to control this behaviour. Only droplets with the "name" tag which were not recently created will be considered for deletion.
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
from
b3d1e5e to
c7d3a7c
Compare
If VAULT_ADDR or VAULT_TOKEN are not provided, the vault client will probably not operate as expected, instead expecting to find a vault server running on localhost. Instead, surface a more helpful error to indicate the environment variable which is missing.
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
from
3cf3cba to
ef7e5c1
Compare
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
from
270a1aa to
332da82
Compare
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
from
a21afc7 to
aa21486
Compare
nicois
force-pushed
the
nicois/clean-up-orphaned-droplets
branch
from
f74b449 to
0450772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any droplets tagged with the
namevalue which are older than a certain amount and still not recognised as a nomad client are considered to be orphans, and will be deleted.