Skip to content

controller: Ensure completed streams are recorded before stopping #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

controller: Ensure completed streams are recorded before stopping #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions myhoard/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,10 @@ def run(self):
assert False, "Invalid mode {}".format(self.mode)
self.wakeup_event.wait(self._get_iteration_sleep())
self.wakeup_event.clear()
if self.mode == self.Mode.active and not self.is_running:
# Update stream statuses before closing controller in case some of the
# streams has just completed so that list of active backups is refreshed
self._update_stream_completed_and_closed_statuses()
except Exception as ex: # pylint: disable=broad-except
self.log.exception("Unexpected exception in mode %s", self.mode)
self.stats.unexpected_exception(ex=ex, where="Controller.run")
Expand Down