Run OPTMIZE TABLE on mysql >= 8.0.29 #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packi
force-pushed
the
packi-optimize-before-backup
branch
2 times, most recently
from
8cedf07 to
c230ef4
Compare
Codecov ReportBase: 76.59% // Head: 76.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 76.59% 76.14% -0.45%
==========================================
Files 16 16
Lines 3905 3924 +19
Branches 932 936 +4
==========================================
- Hits 2991 2988 -3
- Misses 702 718 +16
- Partials 212 218 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
packi
force-pushed
the
packi-optimize-before-backup
branch
from
c230ef4 to
912e295
Compare
packi
force-pushed
the
packi-optimize-before-backup
branch
4 times, most recently
from
2c52a9f to
8a3744d
Compare
kmichel-aiven
previously requested changes
Nov 24, 2022
|
You can add co-author @nicois to your commit, see https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors |
packi
force-pushed
the
packi-optimize-before-backup
branch
from
8a3744d to
42fc7b1
Compare
tkren
reviewed
Nov 24, 2022
packi
force-pushed
the
packi-optimize-before-backup
branch
from
42fc7b1 to
260557a
Compare
Due to changes in the underlying mysql version, it may be required to run OPTIMIZE TABLE on tables which have been ALTERed, to prevent coprruption. xtrabackup detects this situation and reports which tables are impacted, so myhoard simply needs to carry out this operation. Co-authored-by: Nick Farrell <nick.farrell@aiven.io>
packi
force-pushed
the
packi-optimize-before-backup
branch
from
260557a to
15d3df6
Compare
kmichel-aiven
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in the underlying mysql version, it may be required to run OPTIMIZE TABLE on tables which have been ALTERed, to prevent coprruption.
xtrabackup detects this situation and reports which tables are impacted, so myhoard simply needs to carry out this operation.
Initial patch by: Nick Farrell
Obsoletes: #101