Aik 3191 : Also get django context #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aikido_firewall/context/__init__.py
Outdated
| self.query = req.args | ||
| self.cookies = req.cookies | ||
| self.source = "flask" | ||
| if source == "flask": |
There was a problem hiding this comment.
is mss iets meer elegant om maar 1 if statement te hebbne.
There was a problem hiding this comment.
Both ways for me are fine, hele ding was dat er sommige delen gwn voor allebei hetzelfde waren en ik niet dingen 2x wou schrijven, maar in the end is het idd mss clearer als ik het anders doe, one sec
There was a problem hiding this comment.
Something like this might be more extendable also for the future
willem-delbare
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.