Skip to content

fix: unregister video frame delegate in dealloc of TextureRender to a… #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

fix: unregister video frame delegate in dealloc of TextureRender to a… #2296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions shared/darwin/TextureRenderer.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,14 @@ - (void)dispose {
}

- (void)dealloc {
if (self.irisRtcRendering) {
// the delegateId is garenteed to be auto incremented, so we can just remove
// the delegate by the id, no need to check if the delegate is still valid
// or is belong to this TextureRender
self.irisRtcRendering->RemoveVideoFrameObserverDelegate(self.delegateId);
self.irisRtcRendering = nil;
}

dispatch_sync(self.pixelBufferSynchronizationQueue, ^{
if (self.latestPixelBuffer) {
CVPixelBufferRelease(self.latestPixelBuffer);
Expand Down
7 changes: 7 additions & 0 deletions shared/darwin/VideoViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,4 +246,11 @@ - (void)dispose {
[self.textureRenders removeAllObjects];
}

// - (void)dealloc {
// // do not do this, coz TextureRender::TextureRender will call
// // [textureRegistry unregisterTexture] which may already been dealloced by
// // flutter and will bring crash
// // [self dispose];
// }

@end
Loading