Ortho dipole #176
Merged
Ortho dipole #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make it into a general function (not just altitude) - Handles ooblate planets now! - Optional argument to not search ghost cells
MagLat is not defined on the geo grid (yet) > But invLat is made for both the geo grid & mag grid. And included in 'ions'/'bfield' outputs
ideally this is refactored, but whatever. The way this was being done kept messing with the order of points.
- Does not have final pole ghost cells yet...
Here's what I know: - it doesn't run - nan's in density and velocity, i think - maybe in chapman integrals? - k-coord is not right (should be alt above equator, traced along dipole -maybe) - altitude is always negative??? But the rest is good! LOL
- clean up comments, debugging, etc. - fix issue with quadtree values being abs()
…wording. done w this file for now
Need to finish implementing
- The dipole bfield still needs work...
…, corners, edges, etc. - All appears OK except some of the corners. IDK why. Need to commit this and move on. Will revisit & document
snuck in a few variables from previous commit too
- The gradient in the dipole grid is, I think, the same as the spherical grid. Except the k-direction - We can do away with this separate method and just put an if statement around that in calc_gradient_vector?
…work. Hopefully this code can either help someone (me) firgure it out again later, or be deleted. To revert this commit we need to remove the debug flag from the call to test_gradient_ijk. NBD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this has gone on too long and the branches are just too far diverged from each other. I would like to get everything from ortho_dipole into develop. We can then start to work on the things that don't work right. I think that the code is up to a respectable place, so we should be fine bringing it into develop.