Skip to content

Conversation

aaronjridley
Copy link
Contributor

Description

Addresses #153

I have added a bunch of things to enable the code to work in 1D - at a constant lat/lon. There are a bunch of variables that allow discrimination between 0D, 1D, 2D, and 3D grids, but most are not used yet. As we develop the solvers, these will be used.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change that adds functionality)

How Has This Been Tested?

Created a test in tests/1d_alt_tube

Test configuration

  • Operating system: OSX
  • Compiler, version number: gcc version 13.2
  • Any details about your local setup that are relevant

Checklist:

  • [N/A] Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [N/A] Add a note to CHANGELOG.md, summarizing the changes

@aaronjridley aaronjridley self-assigned this Sep 25, 2024
@aaronjridley aaronjridley merged commit 767b60f into dipole_again Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant