Rename "assumed" to "builtin" #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonmarcho
reviewed
Aug 28, 2024
| @@ -20,30 +20,11 @@ module FunDeclId = Types.FunDeclId | |||
| *) | |||
| type var_id = VarId.id [@@deriving show, ord] | |||
|
|
|||
| (** An assumed function identifier, identifying a function coming from a | |||
| (** An built-in function identifier, identifying a function coming from a | |||
| standard library. | |||
| *) | |||
| type assumed_fun_id = | |||
There was a problem hiding this comment.
Shouldn't this also be renamed to builtin_fun_id? :)
sonmarcho
reviewed
Aug 28, 2024
| @@ -100,7 +100,6 @@ let binop_to_string (binop : binop) : string = | |||
| let assumed_fun_id_to_string (aid : assumed_fun_id) : string = | |||
sonmarcho
reviewed
Aug 28, 2024
| parameters (if there are). Adding types which don't satisfy this | ||
| will require to update the code abstracting the signatures (to properly | ||
| take into account the lifetime constraints). | ||
|
|
||
| TODO: update to not hardcode the types (except `Box` maybe) and be more | ||
| modular. | ||
| TODO: move to assumed.rs? | ||
| TODO: move to builtins.rs? | ||
| *) | ||
| type assumed_ty = |
sonmarcho
reviewed
Aug 28, 2024
| @@ -313,12 +313,12 @@ and type_id = | |||
| *) | |||
| | TTuple | |||
| | TAssumed of assumed_ty | |||
|
@sonmarcho That was intentional, this PR is only for the rust side. I'll propagate to the OCaml side separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231. This also removes the
BoxFreebuiltin that no longer exists in rustc, which fixes #230.