Correct 'AnalysisUnit.equals' method

Before this commit, in the 'AnalysisUnit.equals' method, the other value
was compared with itself, resulting in the method returning always true.
Now 'other' is compared to 'this'.

Author: HugoGGuerrier

langkit/templates/java_api/main_class.mako

@@ -3605,7 +3605,7 @@ public final class ${ctx.lib_name.camel} {
             if(this == o) return true;
             if(!(o instanceof AnalysisUnit)) return false;
             final AnalysisUnit other = (AnalysisUnit) o;
-            return other.reference.equals(other.reference);
+            return this.reference.equals(other.reference);
         }
 
     }

testsuite/tests/java_api/general/common/BindingsTests.java

@@ -114,6 +114,20 @@ private static void testUnitFileName() {
         ) {
             // Get the unit for the foo.txt file
             AnalysisUnit unit = context.getUnitFromFile("foo.txt");
+            AnalysisUnit other = context.getUnitFromFile("foo.txt");
+            AnalysisUnit notSame =
+                context.getUnitFromBuffer("var identifier", "bar.txt");
+            System.out.println(
+                unit.toString() + " != " + other + " = " + (unit != other)
+            );
+            System.out.println(
+                unit.toString() + ".equals(" + other + ") = " +
+                unit.equals(other)
+            );
+            System.out.println(
+                unit.toString() + ".equals(" + notSame +
+                ") = " + unit.equals(notSame)
+            );
             System.out.println(
                 "Unit for the file " +
                 new File(unit.getFileName()).getName()

testsuite/tests/java_api/general/graal_c_api/test.out

@@ -6,6 +6,9 @@ Expected '(', got Identifier at <1:5-1:15>
 -------------------
 
 --- Unit Filename ---
+<AnalysisUnit "foo.txt"> != <AnalysisUnit "foo.txt"> = true
+<AnalysisUnit "foo.txt">.equals(<AnalysisUnit "foo.txt">) = true
+<AnalysisUnit "foo.txt">.equals(<AnalysisUnit "bar.txt">) = false
 Unit for the file foo.txt
 ---------------------
 

testsuite/tests/java_api/general/jni/test.out

@@ -6,6 +6,9 @@ Expected '(', got Identifier at <1:5-1:15>
 -------------------
 
 --- Unit Filename ---
+<AnalysisUnit "foo.txt"> != <AnalysisUnit "foo.txt"> = true
+<AnalysisUnit "foo.txt">.equals(<AnalysisUnit "foo.txt">) = true
+<AnalysisUnit "foo.txt">.equals(<AnalysisUnit "bar.txt">) = false
 Unit for the file foo.txt
 ---------------------