minor: Refactor 'Token.equals' operands order

For consistency reasons, move 'this' to the LHS and 'other' to
the RHS in 'Token.equals' method.

Author: HugoGGuerrier

langkit/templates/java_api/main_class.mako

@@ -2685,9 +2685,9 @@ public final class ${ctx.lib_name.camel} {
             if(o == this) return true;
             if(!(o instanceof Token)) return false;
             final Token other = (Token) o;
-            return other.tokenDataHandler.equals(this.tokenDataHandler) &&
-                    other.tokenIndex == this.tokenIndex &&
-                    other.triviaIndex == this.triviaIndex;
+            return this.tokenDataHandler.equals(other.tokenDataHandler) &&
+                    this.tokenIndex == other.tokenIndex &&
+                    this.triviaIndex == other.triviaIndex;
         }
 
         // ----- Inner classes -----

testsuite/tests/java_api/general/common/BindingsTests.java

@@ -168,7 +168,7 @@ private static void testTokens() {
             System.out.println("Text range with a NO_TOKEN = " +
                 Token.textRange(first, none));
 
-            // Test the token equivalence
+            // Test the token equivalence and equality
             AnalysisUnit eqUnit = context.getUnitFromBuffer(
                 "null identifier example identifier example",
                 "foo.txt"
@@ -189,6 +189,20 @@ private static void testTokens() {
                 }
                 current = current.next();
             }
+
+            Token left = eqUnit.getFirstToken();
+            Token right = eqUnit.getFirstToken();
+            while(!(left.isNone() || right.isNone())) {
+                System.out.println(
+                    left.toString() + " != " + right + " = " + (left != right)
+                );
+                System.out.println(
+                    left.toString() + ".equals(" + right + ") = " +
+                    left.equals(right)
+                );
+                left = left.next();
+                right = right.next();
+            }
         }
 
         // Display the footer

testsuite/tests/java_api/general/graal_c_api/test.out

@@ -43,6 +43,26 @@ The NO_TOKEN = <Token Kind=No_Token Text="">
 Text range with a NO_TOKEN = 
 Equivalent tokens : <Token Kind=Identifier Text="identifier"> and <Token Kind=Identifier Text="identifier">
 Equivalent tokens : <Token Kind=Example Text="example"> and <Token Kind=Example Text="example">
+<Token Kind=Null_Tok Text="null"> != <Token Kind=Null_Tok Text="null"> = true
+<Token Kind=Null_Tok Text="null">.equals(<Token Kind=Null_Tok Text="null">) = true
+<Token Kind=Whitespace Text=" "> != <Token Kind=Whitespace Text=" "> = true
+<Token Kind=Whitespace Text=" ">.equals(<Token Kind=Whitespace Text=" ">) = true
+<Token Kind=Identifier Text="identifier"> != <Token Kind=Identifier Text="identifier"> = true
+<Token Kind=Identifier Text="identifier">.equals(<Token Kind=Identifier Text="identifier">) = true
+<Token Kind=Whitespace Text=" "> != <Token Kind=Whitespace Text=" "> = true
+<Token Kind=Whitespace Text=" ">.equals(<Token Kind=Whitespace Text=" ">) = true
+<Token Kind=Example Text="example"> != <Token Kind=Example Text="example"> = true
+<Token Kind=Example Text="example">.equals(<Token Kind=Example Text="example">) = true
+<Token Kind=Whitespace Text=" "> != <Token Kind=Whitespace Text=" "> = true
+<Token Kind=Whitespace Text=" ">.equals(<Token Kind=Whitespace Text=" ">) = true
+<Token Kind=Identifier Text="identifier"> != <Token Kind=Identifier Text="identifier"> = true
+<Token Kind=Identifier Text="identifier">.equals(<Token Kind=Identifier Text="identifier">) = true
+<Token Kind=Whitespace Text=" "> != <Token Kind=Whitespace Text=" "> = true
+<Token Kind=Whitespace Text=" ">.equals(<Token Kind=Whitespace Text=" ">) = true
+<Token Kind=Example Text="example"> != <Token Kind=Example Text="example"> = true
+<Token Kind=Example Text="example">.equals(<Token Kind=Example Text="example">) = true
+<Token Kind=Termination Text=""> != <Token Kind=Termination Text=""> = true
+<Token Kind=Termination Text="">.equals(<Token Kind=Termination Text="">) = true
 --------------
 
 --- Nodes ---

testsuite/tests/java_api/general/jni/test.out

@@ -43,6 +43,26 @@ The NO_TOKEN = <Token Kind=No_Token Text="">
 Text range with a NO_TOKEN = 
 Equivalent tokens : <Token Kind=Identifier Text="identifier"> and <Token Kind=Identifier Text="identifier">
 Equivalent tokens : <Token Kind=Example Text="example"> and <Token Kind=Example Text="example">
+<Token Kind=Null_Tok Text="null"> != <Token Kind=Null_Tok Text="null"> = true
+<Token Kind=Null_Tok Text="null">.equals(<Token Kind=Null_Tok Text="null">) = true
+<Token Kind=Whitespace Text=" "> != <Token Kind=Whitespace Text=" "> = true
+<Token Kind=Whitespace Text=" ">.equals(<Token Kind=Whitespace Text=" ">) = true
+<Token Kind=Identifier Text="identifier"> != <Token Kind=Identifier Text="identifier"> = true
+<Token Kind=Identifier Text="identifier">.equals(<Token Kind=Identifier Text="identifier">) = true
+<Token Kind=Whitespace Text=" "> != <Token Kind=Whitespace Text=" "> = true
+<Token Kind=Whitespace Text=" ">.equals(<Token Kind=Whitespace Text=" ">) = true
+<Token Kind=Example Text="example"> != <Token Kind=Example Text="example"> = true
+<Token Kind=Example Text="example">.equals(<Token Kind=Example Text="example">) = true
+<Token Kind=Whitespace Text=" "> != <Token Kind=Whitespace Text=" "> = true
+<Token Kind=Whitespace Text=" ">.equals(<Token Kind=Whitespace Text=" ">) = true
+<Token Kind=Identifier Text="identifier"> != <Token Kind=Identifier Text="identifier"> = true
+<Token Kind=Identifier Text="identifier">.equals(<Token Kind=Identifier Text="identifier">) = true
+<Token Kind=Whitespace Text=" "> != <Token Kind=Whitespace Text=" "> = true
+<Token Kind=Whitespace Text=" ">.equals(<Token Kind=Whitespace Text=" ">) = true
+<Token Kind=Example Text="example"> != <Token Kind=Example Text="example"> = true
+<Token Kind=Example Text="example">.equals(<Token Kind=Example Text="example">) = true
+<Token Kind=Termination Text=""> != <Token Kind=Termination Text=""> = true
+<Token Kind=Termination Text="">.equals(<Token Kind=Termination Text="">) = true
 --------------
 
 --- Nodes ---