-
Notifications
You must be signed in to change notification settings - Fork 149
Add support for nRF24L01+ radio module #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4a87d11
to
8678cf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend changing each occurrence of "Self" to "This" for the sake of consistency with the rest of the library but that's not the end of the world. ;-)
Indeed. Self to This renaming done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it work for NRF24L01 (without +
)?
examples/shared/nrf24l01p/README.md
Outdated
This is a simple test/example for nRF24L01+ with | ||
STM32F429Disco. Two nRF24L01+ should be connected | ||
to the following board's pins: | ||
TX: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Markdown file is badly formatted. I suggest list items (or table) to make it readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For NRF24L01 Air_Data_Rate should be Rate_1Mbps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like "inversed logic" like No_ACK : Boolean
or
function Is_No_ACK_Allowed
(This : NRF24L01P_Driver;
No_ACK : Boolean) return Boolean;
I prefer ACK : Boolean
and Is_ACK_Required
. It's simpler to reason in "positive logic" for me.
But I don't object if you merge it as is.
No description provided.