chore: fix permission issue for scheduled nightly-build.yml #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As GitHub doesn't like reusable workflows in steps
…s()` alongside now. These commit fixes job failure comment always triggering and posting failure comments regardless if build workflow succeeds
# Conflicts: # .github/workflows/nightly-build.yml # .github/workflows/on-demand-preview-releases-PR.yml
…ll_request.
Important: `pull_request_target` makes the `on-demand-preview-releases-PR.yml` run from base repository with secrets and gives read/write permissions to `$GITHUB_TOKEN` (`secrets.GITHUB_TOKEN`). Unlike normal `pull_request` trigger that has explicit read-ONLY permissions for `$GITHUB_TOKEN`. Meaning secrets and permissions SHOULD BE NOW handled strictly!
Changes:
- checkout `${{ github.event.pull_request.head.sha }}` & sets `persist-credentials: false` to not persist tokens in local git config.
- Adds `skip_tagging_and_releases` input for nightly-build.yml Manual Runs (default: true)
- Adds `CODEOWNERS` file to protect nightly builds and on demand workflows, preventing pushes in PRs without reviews from Authors of the workflow.
Revert: Acode-Foundation@2c37532 for: Acode-Foundation#1628 (comment) ( @peasneovoyager2banana2) has they did Acode-Foundation#1627 before. With All Respect!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QUICK FIX.