Refactor Iap.java: Use WeakReference for Context and Activity to prevent memory leaks #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext and Activity references I used the Weak Reference passing the Context and Activity instead of the old Context and Activity directly, this is done to prevent memory leaks and unexpected closure if the context or activity become null
bajrangCoder
approved these changes
Sep 28, 2024
trindadedev13
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
Iap.javato prevent potential memory leaks by using WeakReference forContextandActivity. This ensures that these references can be garbage collected when necessary, improving memory management.Changes:
ContextandActivityusage withWeakReference.ContextandActivityusingget()fromWeakReference.Motivation:
Avoid memory leaks in cases where the lifecycle of
ContextorActivitymay extend beyond expected, such as during async callbacks or long-running processes.