Skip to content

Conversation

@alMukaafih
Copy link
Contributor

No description provided.

@bajrangCoder
Copy link
Collaborator

bajrangCoder commented Sep 10, 2024

have you tested it? It doesn't work.
You need to properly handle the paid plugin cases etc

@alMukaafih
Copy link
Contributor Author

alMukaafih commented Oct 13, 2024

I have tested it and it works for both free and paid plugins though further testing is needed for paid plugins

@bajrangCoder
Copy link
Collaborator

I have tested it and it works for both free and paid plugins though further testing is needed for paid plugins

Now it's working fine.
Just one thing left:
It should show the name of plugin which is installing in loader and also before installing the dependencies it's nice to show the user that it's going to install these plugins too.

@bajrangCoder bajrangCoder self-assigned this Oct 14, 2024
@bajrangCoder bajrangCoder added enhancement New feature or request plugin api It represents, plugins specific apis enhancement labels Oct 14, 2024
@alMukaafih
Copy link
Contributor Author

I have tested it and it works for both free and paid plugins though further testing is needed for paid plugins

Now it's working fine. Just one thing left: It should show the name of plugin which is installing in loader and also before installing the dependencies it's nice to show the user that it's going to install these plugins too.

Sorry for the late response, was facing some issues irl.

I am deliberately either to show an alert for the dependencies that are going to be installed or a confirmation.
Something like

alert(
    "Installer Notice",
    "Acode is going to install the following dependencies<br/>"
      + plugin.dependencies.join("<br/>"),
    () => {
        // Resolve dependencies
    },
);

Or

const shouldInstall = await confirm(
    "Installer Notice",
    "Acode is going to install the following dependencies<br/>"
      + plugin.dependencies.join("<br/>"),
);

if (shouldInstall) {
    // Resolve dependencies 
}

@bajrangCoder
Copy link
Collaborator

Use confirmation

@alMukaafih
Copy link
Contributor Author

Use confirmation

Ok 👍

@bajrangCoder bajrangCoder merged commit c203c35 into Acode-Foundation:main Dec 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin api It represents, plugins specific apis enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants