-
-
Notifications
You must be signed in to change notification settings - Fork 509
Add Options: Save Image Format choice (PNG/WebP/JPEG), Image Quality, Image Name Format #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ad05d76 to
3e5626f
Compare
3e5626f to
65ee828
Compare
|
There is a conflict since you moved a nearby line. After rebasing and resolving the conflict, the plugin no longer launches for me. I realized there was also a new file and I got that added, but it still will not launch. There are never any error messages in the client.log file that tell me why the plugin doesn't launch, when something goes wrong. Krita.log also doesn't indicate any issues. Where can I look to find the issue? EDIT: Fixed the issue (was missing a symbolic link to another changed file), but it would be good to know how to debug issues going forward. So far I have had to resort to comment out half the remaining code changes until it works again and do that un-commenting half of that, doing a manual binary search to find problematic lines of code. |
…image name format
65ee828 to
8cc24fe
Compare
|
looks good now, will merge later or tomorrow
not sure why you're sumlinking individual files, I think you just want to symlink the entire ai_diffusion folder this covers most of it: https://github.com/Acly/krita-ai-diffusion/blob/main/CONTRIBUTING.md One thing that isn't mentioned, on Windows, to get terminal output from Krita, you need to run And running |
I often have to save many images and then run them through batch converters and renaming scripts, so I added some options to remove this step for myself.
New Options:
Modified:
I had to pass around optional format and quality to the save function and optional quality to the write function. The save function used the file extension to determine format, but we can now be saving 2 different png and 2 different webp formats. The write function used the default quality for each format, but the user may modify these qualities for lossy webp and jpeg by editing the settings.json file.
I couldn't easily figure out how to save the ComfyUI workflow metadata to the jpeg and webp formats, so i left this to someone more qualified than myself. That option remains PNG only, at this time.